Closed Bug 1192249 Opened 9 years ago Closed 7 years ago

Intermittent apps/system/test/marionette/software_home_lockscreen_power_menu_test.js | Software Home Button - Lockscreen Power Menu "before each"/"after each" hook, Leaves room for the SHB in secure-app mode

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Window Mgmt
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.6+)

Status:
RESOLVED WONTFIX
Project Flags:
feature-b2g 2.6+

People

(Reporter: RyanVM, Unassigned)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe] [MJS] [intermittents])

Attachments

(2 files)

[gaia] mikehenrty:bug-1192249-wait-for-lockscreen-power-menu-test > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review
[gaia] mikehenrty:bug-1192249-just-disable-it > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review 
      No description provided.
Greg, this is one of the more frequent Lockscreen failures at the moment. Can you please take a look?
Flags: needinfo?(gweng)
From the code, the stacktrace[1] and the failures, I don't see anything really caused by LockScreen. Should we change it to SHB? Or do you watched something that I haven't discovered from that?

[1]: for example, the stacktrace of this: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=2618902
Flags: needinfo?(gweng)
Summary: Intermittent apps/system/test/marionette/software_home_lockscreen_power_menu_test.js | Software Home Button - Lockscreen Power Menu "before each"/"after each" hook → Intermittent apps/system/test/marionette/software_home_lockscreen_power_menu_test.js | Software Home Button - Lockscreen Power Menu "before each"/"after each" hook, Leaves room for the SHB in secure-app mode
Component: Gaia::System::Lockscreen → Gaia::System::Window Mgmt
Sorry for such a long late change: from LockScreen I can't figure anything, so I change the component first. If anyone find anything new in LockScreen code, please NI me and I will change the component again.
We'll need to address this one too if we want to land bug 1222215. Taking a look.
Assignee: nobody → mhenretty
Blocks: 1222215
Whiteboard: [systemsfe]
Comment on attachment 8684902 [details] [review]
[gaia] mikehenrty:bug-1192249-wait-for-lockscreen-power-menu-test > mozilla-b2g:master

Waiting for the lockscreen to disappear before bringing up the power menu seems to make the situation better.

Greg, will you take a look?
Attachment #8684902 - Flags: review?(gweng)
Comment on attachment 8684902 [details] [review]
[gaia] mikehenrty:bug-1192249-wait-for-lockscreen-power-menu-test > mozilla-b2g:master

The code is good to me, thanks.
Attachment #8684902 - Flags: review?(gweng) → review+
master: https://github.com/mozilla-b2g/gaia/commit/f10062acefdf0a0fb67253917ceeb13ebcaa70a7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
didn't fix it :( 

https://public-artifacts.taskcluster.net/Gqu0lV9CQ-Op46v_KDGWCw/0/public/logs/live_backing.log
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
feature-b2g: --- → 2.6+
Whiteboard: [systemsfe] → [systemsfe] [MJS]
Michael, I am told that this should be addressed before end-of-year, as part of Continuous Integration Program. Are you still working on this?
Flags: needinfo?(mhenretty)

  

  



    
    

    
  
I am not currently working on this, and as part of the CIP I'm going to disable all tests that block bug 1222215. So landing the above patch with a=test-only, and leaving this open for now.

disabled in master: https://github.com/mozilla-b2g/gaia/commit/dbecc0dc188c9e1235321481bc2d98899357e211

  

  


Assignee: mhenretty → nobody
Flags: needinfo?(mhenretty)

    
    

    
  
Removing the dependency since it's now disabled.

  

  


No longer blocks: 1222215

    
    

    
      
  
Whiteboard: [systemsfe] [MJS] → [systemsfe] [MJS] [intermittents]

    
    

    
  
Firefox OS is not being worked on

  

  


Status: REOPENED → RESOLVED
Closed: 9 years ago → 7 years ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: