1192267 - [Messages] The report view animation should not be a panel animation, but should be a dialog animation.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

This is a regression of bug 1162030.

STR:
1. Open the SMS app.
2. Open an existing conversation.
3. Long press on a message, select "view message report".

Expected:
* There is a "dialog" animation appearing.

Actual:
* There is a "slide-panel" animation appearing.

Note that before bug 1162030 we had no animation whatsoever. Maybe UX can decide whether a "slide-panel" animation is good enough, and in that case we might decide to change the top left "cross" icon to a "back" icon. This bug could be bugmorphed to do this instead of UX feels like it.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Hey Julien, can we have the same fade in animation as seen in email when you try to delete a message. I don't believe we have slide in dialogs anywhere so I wouldn't want to introduce this 1 unique animation.

Comment 2

[Julien Wajsberg [:julienw]]

Yes sure, this is what I call the "dialog" animation :) 

IMO the 2 alternatives are:
* either keep this a "dialog" like; then we should change the animation.
* or make it more like another "panel" with a top left arrow, with the sliding animation.

What would you prefer ?

IMO this is more like a dialog, so I'd do more the 1st alternative, but this is quite more work, so if keeping it as a panel works for you this also works for me.

Comment 3

[Patryk Adamczyk [:patryk] UX]

Yes I agree it feels more like a dialog (purpose wise). I'd let Rob comment as well since like you said if we convert it to a dialog its a bunch of work, so I'd want to get a consensus on the topic.

Comment 4

[Julien Wajsberg [:julienw]]

Just to precise: it's not _that_ much work either :) We're talking about either a small patch or a very small patch here.

Comment 5

[Patryk Adamczyk [:patryk] UX]

Julien, so spoke with the rest of the team.
1. All the dialog animations in the SMS need to be fixed. In all other instances it FADES IN and in SMS it slides up. So it should FADE IN.
2. The message report should also FADE IN, and not SLIDE IN

Thanks!

Comment 6

[Julien Wajsberg [:julienw]]

Thanks Patryk !

(In reply to Patryk Adamczyk [:patryk] UX from comment #5)

> 1. All the dialog animations in the SMS need to be fixed. In all other
> instances it FADES IN and in SMS it slides up. So it should FADE IN.

Filed separate bug 1199567 as it's not a regression and it's different code.

> 2. The message report should also FADE IN, and not SLIDE IN

Requesting blocking status again for this regression.

Comment 7

[Julien Wajsberg [:julienw]]

I realize I missed my "requesting blocking status again" from previous comment... Too late for 2.5 for this non-critical regression, but we should fix this in v2.6.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Not blocking right now, if you want to get this fix in 2.6, please go ahead and land this on master.

Comment 9

[Julien Wajsberg [:julienw]]

We should especially reuse the shared animations.css.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] julienw:1192267-right-animation-for-report-view > mozilla-b2g:master

Comment 11

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 12

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(