Closed Bug 1192331 Opened 4 years ago Closed 4 years ago

Reenable test_modal_dialogs.py

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: adw, Assigned: cmanchester)

References

Details

Attachments

(1 file)

Bug 959567 was causing test_modal_dialogs.py to consistently time out on tryserver.  We wanted to land that bug ASAP so I disabled the test: https://hg.mozilla.org/mozilla-central/diff/4e2489f7cc7d/testing/marionette/client/marionette/tests/unit/unit-tests.ini

I wanted to fix it instead but couldn't figure out why it was timing out.  It looks like the test has to do with modal dialogs, which bug 959567 shouldn't have caused a problem for.

Henrik, could you look into why it's failing?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59830f6d8909

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/dwillcoxon@mozilla.com-59830f6d8909/try-linux-debug/try_ubuntu32_vm-debug_test-marionette-bm03-tests1-linux32-build1307.txt.gz

> ...
> 16:48:09     INFO -  TEST-START | test_with_using_context.py TestSetContext.test_set_same_context_using_with_block
> 16:48:10     INFO -  TEST-PASS | test_with_using_context.py TestSetContext.test_set_same_context_using_with_block | took 714ms
> 16:48:10     INFO -  TEST-START | test_with_using_context.py TestSetContext.test_set_scope_while_in_with_block
> 16:48:11     INFO -  TEST-PASS | test_with_using_context.py TestSetContext.test_set_scope_while_in_with_block | took 1016ms
> 16:48:11     INFO -  TEST-START | test_modal_dialogs.py TestGlobalModals.test_alert_accept
> 16:48:28    ERROR -  TEST-UNEXPECTED-ERROR | test_modal_dialogs.py TestGlobalModals.test_alert_accept | TimeoutException: TimeoutException: Timed out after 5.2 seconds
> 16:48:28     INFO -  Traceback (most recent call last):
> 16:48:28     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 296, in run
> 16:48:28     INFO -      testMethod()
> 16:48:28     INFO -    File "/builds/slave/test/build/tests/marionette/tests/testing/marionette/client/marionette/tests/unit/test_modal_dialogs.py", line 38, in test_alert_accept
> 16:48:28     INFO -      self.wait_for_alert()
> 16:48:28     INFO -    File "/builds/slave/test/build/tests/marionette/tests/testing/marionette/client/marionette/tests/unit/test_modal_dialogs.py", line 30, in wait_for_alert
> 16:48:28     INFO -      Wait(self.marionette).until(lambda _: self.alert_present())
> 16:48:28     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette_driver/wait.py", line 143, in until
> 16:48:28     INFO -      cause=last_exc)
> 16:48:28     INFO -  TEST-INFO took 16640ms
> 16:48:28     INFO -  TEST-START | test_modal_dialogs.py TestGlobalModals.test_alert_dismiss
> 16:48:30     INFO -  TEST-PASS | test_modal_dialogs.py TestGlobalModals.test_alert_dismiss | took 1533ms
> 16:48:30     INFO -  TEST-START | test_modal_dialogs.py TestGlobalModals.test_alert_text
> 16:48:31     INFO -  TEST-PASS | test_modal_dialogs.py TestGlobalModals.test_alert_text | took 1756ms
> ...
The dialog/popup added by bug 959567 blocks the alert opened by the test. I think we just need to pref it off. Patch coming up.
Assignee: nobody → cmanchester
Bug 1192331 - Disable search suggestions UI when running marionette tests and re-enable modal test. r=adw
Attachment #8645098 - Flags: review?(adw)
Comment on attachment 8645098 [details]
MozReview Request: Bug 1192331 - Disable search suggestions UI when running marionette tests and re-enable modal test. r=adw

https://reviewboard.mozilla.org/r/15385/#review13767

Setting browser.urlbar.userMadeSearchSuggestionsChoice=true is probably the right thing to do but I don't think I'm "officially" allowed to r+ Marionette patches. :-)
Attachment #8645098 - Flags: review?(adw) → review+
And thanks for fixing it so quickly.
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/ff5f77b0dc71
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.