Closed Bug 1192462 Opened 5 years ago Closed 5 years ago

Augment import-locales.sh and/or update-xliff.py to allow the list of included locales to be specified

Categories

(Firefox for iOS :: Build & Test, defect)

All
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: rnewman, Assigned: st3fan)

Details

Attachments

(1 file)

We'll need to do this to import only completed locales into the v1.0 and v1.1 builds.
Assignee: nobody → sarentz
This change to `import-locales.sh` adds a `--only-complete` flag to the script. If this is specified then the script will remove locales that are not complete, after checking out the initial l10n repository.

To keep things simple, the list of incomplete locales is kept inside the script. This means that before we do a final build, this list needs to be updated. The best place to see what locales are ready to go is the [https://l10n.mozilla-community.org/~flod/webstatus/?product=firefox-ios](L10N Dashboard).
Attachment #8647103 - Flags: review?(sleroux)
Adding some people to this bug to be sure.
Attachment #8647103 - Flags: review?(francesco.lodolo)
QA Contact: sarentz
Comment on attachment 8647103 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/915

I agree with Flod's comments. I'm going to clear myself for review on this one.
Attachment #8647103 - Flags: review?(sleroux)
Included :flod's improved shell code. Merging this into master so that it can be updated on release build day.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8647103 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/915

r+ on the current version, still need to think more about getting that list of locales directly from the dashboard.
Attachment #8647103 - Flags: review?(francesco.lodolo) → review+
You need to log in before you can comment on or make changes to this bug.