1192462 - Augment import-locales.sh and/or update-xliff.py to allow the list of included locales to be specified

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Richard Newman [:rnewman]]

We'll need to do this to import only completed locales into the v1.0 and v1.1 builds.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/915

This change to `import-locales.sh` adds a `--only-complete` flag to the script. If this is specified then the script will remove locales that are not complete, after checking out the initial l10n repository.

To keep things simple, the list of incomplete locales is kept inside the script. This means that before we do a final build, this list needs to be updated. The best place to see what locales are ready to go is the [https://l10n.mozilla-community.org/~flod/webstatus/?product=firefox-ios](L10N Dashboard).

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Adding some people to this bug to be sure.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8647103 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/915

I agree with Flod's comments. I'm going to clear myself for review on this one.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Included :flod's improved shell code. Merging this into master so that it can be updated on release build day.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I have added instructions to https://github.com/mozilla/firefox-ios/wiki/Building-for-Distribution

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8647103 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/915

r+ on the current version, still need to think more about getting that list of locales directly from the dashboard.