1192467 - Formalize precondition that SetDisplayDocument must not be called with null

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: 0006-Add-non-null-precondition-mentioned-in-comment.patch

It's mentioned in the comment, but not actually added to the NS_PRECONDITIONs.

Running MSVC static analysis complains about possible null-deref without this.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

MOZ_ASSERT for all new assertions, please.

Comment 2

[Kelsey Gilbert [:jgilbert]]

(In reply to :Ms2ger from comment #1)
> MOZ_ASSERT for all new assertions, please.

I do prefer it, but I was miming local code. Should I change the others in this function?

If only the new one is MOZ_ASSERT, it will look like it's MOZ_ASSERT instead of NS_PRECONDITION for a reason, when it's really two names for the same thing. (Though NS_PRECONDITION has a little extra context for the reason for the assertion)

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Making them all MOZ_ASSERT would be nice too :)

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: 0002-s-NS_PRECONDITION-MOZ_ASSERT-in-nsIDocument.h.patch

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/791d46775391

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/791d46775391