1192484 - Fix selecting without paths or tags in mach try

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I added an assert when addressing a review comment for bug 1183232 -- "assert tags or paths" -- that is bogus. Returning an empty dict does what we want here.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Remove bogus assert to fix selection without paths or tags in mach try

Sorry about the splinter review (I can't seem to push right now). It's a short one.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c997abf7973f

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c997abf7973f

Comment 4

[Chris Manchester (limited bugmail, email directly)]

I was pointing someone towards this feature and they pointed out it's still broken.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1192484 - Fix incorrect order of operations preventing selection by tag. r=ahal

Bug 1192484 - Fix incorrect order of operations preventing selection by tag. r=ahal

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Apparently I never tested the original fix. Sorry for the churn here.

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8653778 [details]
MozReview Request: Bug 1192484 - Fix incorrect order of operations preventing selection by tag. r=ahal

https://reviewboard.mozilla.org/r/17511/#review15693

No worries

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f2f45c700d1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f2f45c700d1