Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fix selecting without paths or tags in mach try

RESOLVED FIXED in Firefox 43

Status

Testing
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
I added an assert when addressing a review comment for bug 1183232 -- "assert tags or paths" -- that is bogus. Returning an empty dict does what we want here.
(Assignee)

Comment 1

2 years ago
Created attachment 8645304 [details] [diff] [review]
Remove bogus assert to fix selection without paths or tags in mach try

Sorry about the splinter review (I can't seem to push right now). It's a short one.
Attachment #8645304 - Flags: review?(ahalberstadt)
(Assignee)

Updated

2 years ago
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
Attachment #8645304 - Flags: review?(ahalberstadt) → review+

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c997abf7973f
https://hg.mozilla.org/mozilla-central/rev/c997abf7973f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
(Assignee)

Comment 4

2 years ago
I was pointing someone towards this feature and they pointed out it's still broken.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

2 years ago
Created attachment 8653778 [details]
MozReview Request: Bug 1192484 - Fix incorrect order of operations preventing selection by tag. r=ahal

Bug 1192484 - Fix incorrect order of operations preventing selection by tag. r=ahal
Attachment #8653778 - Flags: review?(ahalberstadt)
(Assignee)

Comment 6

2 years ago
Apparently I never tested the original fix. Sorry for the churn here.
Attachment #8653778 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8653778 [details]
MozReview Request: Bug 1192484 - Fix incorrect order of operations preventing selection by tag. r=ahal

https://reviewboard.mozilla.org/r/17511/#review15693

No worries

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f2f45c700d1
https://hg.mozilla.org/mozilla-central/rev/5f2f45c700d1
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.