1192693 - Remove bluetooth1 code from Bluetooth

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Remove bluetooth1 code since we've moved to bluetooth2 on m-c.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Remove bluetooth1 folder and webidl files

Comment 2

[Ben Tian (inactive)]

Attachment: [final] Patch 3: Remove bluetooth1 code from backend, r=tzimmermann

Comment 3

[Ben Tian (inactive)]

Comment on attachment 8645535 [details] [diff] [review]
[final] Patch 3: Remove bluetooth1 code from backend, r=tzimmermann

Review of attachment 8645535 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +635,2 @@
>          DispatchReplySuccess(mRequests[0].mRunnable,
>                               mRequests[0].mDevicesPack);

Note I decide to adopt bluetooth1 semantics here for comment above [1].

[1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp#868

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8645535 [details] [diff] [review]
[final] Patch 3: Remove bluetooth1 code from backend, r=tzimmermann

Review of attachment 8645535 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah! \o/

Comment 5

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Remove bluetooth manager, adapter, and device webidl files, r=joliu

Break original patch 1 into 2 patches to keep hg history of new webidl file. The is the first patch.

Comment 6

[Ben Tian (inactive)]

Attachment: [final] Patch 2: Remove bluetooth1 folder and rename webidl files, r=joliu

Here's patch 2.

Comment 7

[Ben Tian (inactive)]

Comment on attachment 8645535 [details] [diff] [review]
[final] Patch 3: Remove bluetooth1 code from backend, r=tzimmermann

Re-number to patch 3.

Comment 8

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8646174 [details] [diff] [review]
[final] Patch 1: Remove bluetooth manager, adapter, and device webidl files, r=joliu

Review of attachment 8646174 [details] [diff] [review]:
-----------------------------------------------------------------

Please point out these are legacy files in the commit log.

Comment 9

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8646175 [details] [diff] [review]
[final] Patch 2: Remove bluetooth1 folder and rename webidl files, r=joliu

Review of attachment 8646175 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks a lot for the effort!
Please help to open a follow up bug to mv files under dom/bluetooth/bluetooth2 to dom/bluetooth or any other better places.

Comment 11

[Ben Tian (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0f2e9c10491

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This is apparently missing review by a DOM peer for the webidl changes, so I can't land these. :(

Comment 13

[Ben Tian (inactive)]

(In reply to Wes Kocher (:KWierso) from comment #12)
> This is apparently missing review by a DOM peer for the webidl changes, so I
> can't land these. :(

Sorry my bad. I forgot the DOM peer review.

Comment 14

[Ben Tian (inactive)]

Comment on attachment 8646174 [details] [diff] [review]
[final] Patch 1: Remove bluetooth manager, adapter, and device webidl files, r=joliu

Blake,

Can you help review my patches that remove legacy bluetooth API webidl files?

There are two patches: the first patch removes legacy bluetooth webidl files, and the second one renames new webidl files and does the rest of the change. The reason to break into two patches is to keep hg history of new webidl files per comment 5.

Comment 15

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Remove legacy bluetooth manager, adapter, and device webidl files, r=joliu

Revise commit log.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/4512aa73da7d
https://hg.mozilla.org/integration/b2g-inbound/rev/2af7381b4711
https://hg.mozilla.org/integration/b2g-inbound/rev/b68a4959c55a

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4512aa73da7d
https://hg.mozilla.org/mozilla-central/rev/2af7381b4711
https://hg.mozilla.org/mozilla-central/rev/b68a4959c55a