1192708 - Remove redundant call to CloseChannel in ChannelMediaResource::CacheClientSeek

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

We should call CloseChannel() just once no matter mSuspendCount turns out to be zero or not.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

See https://hg.mozilla.org/mozilla-central/file/d6ea652c5799/dom/media/MediaResource.cpp#l1039

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1192708_remove_extra_CloseChannel-v1.patch

Per comment 0, CloseChannel() needs to be called once only. The only thing unclear is whether to set mIgnoreClose to true.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a140a7139bc
See if this innocent change breaks anything.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the feedback. I will rephrase the comment and upload a new patch for review.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1192708 - Remove redundant call to CloseChannel.

Bug 1192708 - Remove redundant call to CloseChannel.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8647275 [details]
MozReview Request: Bug 1192708 - Remove redundant call to CloseChannel.

https://reviewboard.mozilla.org/r/15969/#review14273

Ship It!

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c50d6b8b009

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c50d6b8b009