Closed Bug 1192708 Opened 7 years ago Closed 7 years ago

Remove redundant call to CloseChannel in ChannelMediaResource::CacheClientSeek

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

We should call CloseChannel() just once no matter mSuspendCount turns out to be zero or not.
Depends on: 774901
Per comment 0, CloseChannel() needs to be called once only. The only thing unclear is whether to set mIgnoreClose to true.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8645575 - Flags: feedback?(roc)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a140a7139bc
See if this innocent change breaks anything.
Thanks for the feedback. I will rephrase the comment and upload a new patch for review.
Bug 1192708 - Remove redundant call to CloseChannel.
Attachment #8647275 - Flags: review?(roc)
Blocks: 1187092
Comment on attachment 8647275 [details]
MozReview Request: Bug 1192708 - Remove redundant call to CloseChannel.

https://reviewboard.mozilla.org/r/15969/#review14273

Ship It!
Attachment #8647275 - Flags: review?(roc) → review+
Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/8c50d6b8b009
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.