Closed
Bug 1192754
Opened 10 years ago
Closed 10 years ago
[Messages][a11y] Bug 1162030 regressed the panel visibility
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:2.5+, b2g-master fixed)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: julienw, Assigned: julienw)
References
Details
(Keywords: access, regression, Whiteboard: [sms-sprint-FxOS-S5])
Attachments
(1 file)
In Bug 995035 the a11y team added aria-hidden to panels that were not visible by the user.
This was removed in bug 1162030 by mistake (because initially we were using "display: none" for invisible displays, but this was then changed). We need to add this back.
Basically bug 995035 should be readded to the current code.
|
||
Updated•10 years ago
|
blocking-b2g: 2.5? → 2.5+
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8647456 [details] [review]
[gaia] julienw:1192754-navigation-add-aria-hidden > mozilla-b2g:master
Hey Oleg,
here is a simple patch to put back aria-hidden handling. I think that if I'd screwed up the marionette tests would fail (haven't tried though :) ).
Attachment #8647456 -
Flags: review?(azasypkin)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → felash
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [sms-sprint-FxOS-S5]
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8647456 [details] [review]
[gaia] julienw:1192754-navigation-add-aria-hidden > mozilla-b2g:master
LGTM, just one optional nit.
Thanks!
Attachment #8647456 -
Flags: review?(azasypkin) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
master: 2bed7e70b23cc54144d7225df6178e9911427d5a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
status-b2g-master:
--- → fixed
Target Milestone: --- → FxOS-S5 (21Aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•