Bug 1186529 introduced a regression. Home panels with grids added by add-ons are not clickable anymore. Change introducing the regression: http://hg.mozilla.org/integration/fx-team/rev/c9b41f67d832
The bug is not directly related to the new code handling clicks but to the way we draw the touch hightlight using a clickable container in panel_item_container.xml
Comment on attachment 8645692 [details] [diff] [review] 1192780-click-highlight.patch Review of attachment 8645692 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the catch! LGTM.
Attachment #8645692 - Flags: review?(jalmeida) → review+
url: https://hg.mozilla.org/integration/fx-team/rev/9086a226f26de0aa92100ec54c7c8ba14b1ed1cf changeset: 9086a226f26de0aa92100ec54c7c8ba14b1ed1cf user: Sebastian Kaspari <email@example.com> date: Tue Aug 11 10:16:35 2015 +0200 description: Bug 1192780 - panel_item_container: Remove unnecessary view for click highlighting. r=jonalmeida
Comment on attachment 8645692 [details] [diff] [review] 1192780-click-highlight.patch Approval Request Comment [Feature/regressing bug #]: Bug 1157539 [User impact if declined]: Clicks on speed dial panels added by add-ons are ignored, making them effectively useless. [Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee459318b3fb [Risks and why]: Low risk. This patch is just touching the speed dial item that should be clickable [String/UUID change made/needed]: -
Attachment #8645692 - Flags: approval-mozilla-aurora?
4 years ago
Comment on attachment 8645692 [details] [diff] [review] 1192780-click-highlight.patch Important issue in a new feature, taking it.
Attachment #8645692 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reproduced the issue with the 10-08 Nightly build with the instagram panel add-on. Verified as fixed on Firefox for Android 43.0a1 (2015-08-17) using LG Nexus 4 (Android 5.0).
Verified as fixed using speed dial add-on, on Firefox for Android 42.0a2 (2015-09-03) with LG Nexus 4 (Android 5.1)
You need to log in before you can comment on or make changes to this bug.