1192780 - Regression: Home panel grids added by add-ons are not clickable

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Bug 1186529 introduced a regression. Home panels with grids added by add-ons are not clickable anymore.

Change introducing the regression: http://hg.mozilla.org/integration/fx-team/rev/c9b41f67d832

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

The bug is not directly related to the new code handling clicks but to the way we draw the touch hightlight using a clickable container in panel_item_container.xml

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1192780-click-highlight.patch

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee459318b3fb

Comment 4

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 8645692 [details] [diff] [review]
1192780-click-highlight.patch

Review of attachment 8645692 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the catch! LGTM.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

url:        https://hg.mozilla.org/integration/fx-team/rev/9086a226f26de0aa92100ec54c7c8ba14b1ed1cf
changeset:  9086a226f26de0aa92100ec54c7c8ba14b1ed1cf
user:       Sebastian Kaspari <[e-mail]>
date:       Tue Aug 11 10:16:35 2015 +0200
description:
Bug 1192780 - panel_item_container: Remove unnecessary view for click highlighting. r=jonalmeida

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8645692 [details] [diff] [review]
1192780-click-highlight.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1157539
[User impact if declined]: Clicks on speed dial panels added by add-ons are ignored, making them effectively useless.
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee459318b3fb
[Risks and why]: Low risk. This patch is just touching the speed dial item that should be clickable
[String/UUID change made/needed]: -

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9086a226f26d

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8645692 [details] [diff] [review]
1192780-click-highlight.patch

Important issue in a new feature, taking it.

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Reproduced the issue with the 10-08 Nightly build with the instagram panel add-on.
Verified as fixed on Firefox for Android 43.0a1 (2015-08-17) using LG Nexus 4 (Android 5.0).

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1cfe65791f1c

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using speed dial add-on, on Firefox for Android 42.0a2 (2015-09-03) with LG Nexus 4 (Android 5.1)