Closed Bug 1192814 Opened 9 years ago Closed 9 years ago

Off-by-one error when long pressing home panel grid item

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
42 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed, firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

Details

Attachments

(1 file)

1192814-off-by-one.patch
1.89 KB, patch
jonalmeida
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Long-pressing a grid item of a home panel added by an add-on shows the context menu of the wrong item. Long pressing the last item crashes the application.

        Attachment #8645694 -
        Flags: review?(jalmeida)

    
    

    
  
Comment on attachment 8645694 [details] [diff] [review]
1192814-off-by-one.patch

Review of attachment 8645694 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

        Attachment #8645694 -
        Flags: review?(jalmeida) → review+

    
    

    
  
url:        https://hg.mozilla.org/integration/fx-team/rev/f84da9454b1d82a610ddacd24527d60dbd6b7a28
changeset:  f84da9454b1d82a610ddacd24527d60dbd6b7a28
user:       Sebastian Kaspari <s.kaspari@gmail.com>
date:       Tue Aug 11 10:22:39 2015 +0200
description:
Bug 1192814 - PanelRecyclerView: Create context menu for header. r=jonalmeida

    
    

    
  
Comment on attachment 8645694 [details] [diff] [review]
1192814-off-by-one.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1172136
[User impact if declined]: If a speed dial added by an add-on uses a large header image (bug 1172136) then the context menu that shows up when long pressing an item is off-by-one. When long pressing the last item of the speed dial then the app crashes.
[Describe test coverage new/current, TreeHerder]: Local testing with speed dial demo add-on. This is not covered by a UI test.
[Risks and why]: Changed code is only touching the long press handler. So it really can't get worse.
[String/UUID change made/needed]: -

        Attachment #8645694 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f84da9454b1d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox43:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43

    
    

    
  
Comment on attachment 8645694 [details] [diff] [review]
1192814-off-by-one.patch

Fix an obvious problem, taking it.

        Attachment #8645694 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: