119284 - Invalid language attribute selects Arabic glyphs

Status: VERIFIED DUPLICATE of bug 128338

(Core :: Internationalization, defect)

Description

[Joe Smith]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7) Gecko/20011226
BuildID:    2001122617

<font> tags containing an invalid 'lang' attribute (e.g. lang="0") select an
Arabic glyph set.

GIGO of course, except that the AOL mailer apparently generates these tags, thus
they are very commonly encountered.  IE6 and the other browsers I have access to
simply ignore invalid langage codes.


Reproducible: Always
Steps to Reproduce:
1.render any html with a <font lang="0"> tag.  The default font, or a font
specified in the <font> tag must be a Unicode font (otherwise it won't have
alternate encoding).


Actual Results:  Text is rendered in Arabic glyphs.

Expected Results:  Ignore the invalid language attribute.

Comment 1

[Christopher Hoess (gone)]

tentatively ->il8n

Comment 2

[Roy Yokoyama]

assigning to smontagu for i18n-bidi
smontagu:  do you know why it results to arabic?

Comment 3

[Simon Montagu :smontagu]

I can't reproduce the bug, but I think there is a problem with the handling of
unrecognized language attributes at
http://lxr.mozilla.org/mozilla/source/intl/locale/src/nsLanguageAtomService.cpp#204 

Comment 4

[Simon Montagu :smontagu]

Attachment: Suggested patch (diff -u -w)

Comment 5

[Simon Montagu :smontagu]

Attachment: Same as attachment 65132, with diff -u

Comment 6

[Yuying Long]

I can not reproduce the original problem either (don't see the aribic part).
But since simon has a patch, I'd confirm this bug in order to get fix check in.

Comment 7

[Simon Montagu :smontagu]

ftang, can you r= the patch?

Comment 8

[Simon Montagu :smontagu]

Reporter, do you make your own builds? If so, can you try applying attachment
65135 [details] [diff] [review] to test if it solves the problem? If nobody here can reproduce the bug,
this may be difficult to review ;-)

Comment 9

[Joe Smith]

> Reporter, do you make your own builds?

Never have, but I should be able to try one.

It seems to be an interaction with the particular X installation.
I can only reproduce the problem when it is displayed on my workstation.
Even the same Linux install (RH7.2) and the same mozilla binary on another
machine don't show the problem (unless I display it on my workstation).  I'm not
sure what the differences (upgrades, etc) are between the two installs.

Comment 10

[Shanjian Li]

This is a dup of bug 128338. Simon, could you review that patch?

*** This bug has been marked as a duplicate of 128338 ***

Comment 11

[Yuying Long]

It's a dup of bug 128338 for me too.

Mark it as verified, please re-open if disagree.

Comment 12

[Joe Smith]

Verified fixed for me using locally compiled nightly:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9+) Gecko/20020328