Closed Bug 1192926 Opened 6 years ago Closed 6 years ago

Hide system add-ons from the add-ons manager

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

We don't want these to show in the main UI.
Blocks: 1183866
Assignee: nobody → dtownsend
Bug 1192926: Hide system add-ons from the add-ons manager. r?rhelmer

We've wanted a hidden property for add-ons for a while so we can do things like
hide "uninstalled" sideloaded add-ons so this adds the basic version of it to
hide system add-ons.
Attachment #8665570 - Flags: review?(rhelmer)
Comment on attachment 8665570 [details]
MozReview Request: Bug 1192926: Hide system add-ons from the add-ons manager. r?rhelmer

https://reviewboard.mozilla.org/r/20259/#review18343

::: toolkit/mozapps/extensions/internal/XPIProvider.jsm:6810
(Diff revision 1)
> +  this.__defineGetter__("hidden", function AddonWrapper_hidden() {

I hadn't seen this way of definine a getter so looked into it, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/__defineGetter__ says it is deprecated in favor of `defineProperty`.

I see `__defineGetter__` is already used in this file and you're probably already aware of this, just noticed :)
Attachment #8665570 - Flags: review?(rhelmer) → review+
(In reply to Robert Helmer [:rhelmer] from comment #2)
> Comment on attachment 8665570 [details]
> MozReview Request: Bug 1192926: Hide system add-ons from the add-ons
> manager. r?rhelmer
> 
> https://reviewboard.mozilla.org/r/20259/#review18343
> 
> ::: toolkit/mozapps/extensions/internal/XPIProvider.jsm:6810
> (Diff revision 1)
> > +  this.__defineGetter__("hidden", function AddonWrapper_hidden() {
> 
> I hadn't seen this way of definine a getter so looked into it,
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/
> Global_Objects/Object/__defineGetter__ says it is deprecated in favor of
> `defineProperty`.
> 
> I see `__defineGetter__` is already used in this file and you're probably
> already aware of this, just noticed :)

Yeah as I was looking over this I was thinking it would be wonderful to replace all that gunk with the nicer new JS features we have now. I just filed bug 1208631 on it.
https://hg.mozilla.org/mozilla-central/rev/cc22ed2cafd3
https://hg.mozilla.org/mozilla-central/rev/4093d5840098
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.