1192947 - OpenH264: crash [@WelsDec::WelsReorderRefList]

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: call_stack.txt

May be related to bug 1192929

Comment 1

[Tyson Smith [:tsmith]]

Attachment: test_case.264

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

What code is this being reported against?  1.4 or trunk?  It may not matter, but what platform?

Comment 3

[Tyson Smith [:tsmith]]

(In reply to Randell Jesup [:jesup] from comment #2)
> What code is this being reported against?  1.4 or trunk?  It may not matter,
> but what platform?

I should have updated this one as well. Again found in trunk. My intention is to prevent these issues from creeping in to our next update.

Comment 4

[Daniel Veditz [:dveditz]]

Not sure how to rate this given the GMP sandbox. Are we comfortable with that as a mitigation? compromising on sec-high for now, we need this fixed.

Comment 5

[Tyson Smith [:tsmith]]

Attachment: call_stack.txt

Comment 6

[Haibo Zhu]

It is caused by the recently modification and we have fixed it in latest code, please help to check it.

Comment 7

[Tyson Smith [:tsmith]]

Verified with https://github.com/cisco/openh264/commit/8a96d06fa2fded2ac7f7c2b02942347fe8fc6d45

Comment 8

[Tyson Smith [:tsmith]]

(In reply to Tyson Smith [:tsmith] from comment #7)
> Verified with
> https://github.com/cisco/openh264/commit/
> 8a96d06fa2fded2ac7f7c2b02942347fe8fc6d45
Sorry that should be https://github.com/cisco/openh264/commit/195dbdd5bdfefdf5c7ede511d1c088da493b559e