Closed Bug 1192982 Opened 8 years ago Closed 8 years ago

Use of strncpy in |addRange| in nptest.cpp can result in unterminated cstr

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 affected, firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox43 --- affected
firefox45 --- fixed

People

(Reporter: erahm, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1274374])

Attachments

(1 file)

Bug 1192982.diff
1.26 KB, patch
jaas
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #517078 +++

Note: this is just in test code.

Coverity indicates |addRange| uses strncpy [1] in a way that can lead to an unterminated string buffer.

[1] https://hg.mozilla.org/mozilla-central/annotate/d6ea652c579992daa9041cc9718bb7c6abefbc91/dom/plugins/test/testplugin/nptest.cpp#l426
Assignee: nobody → bogdan.postelnicu
Attached patch Bug 1192982.diff — — Splinter Review 
Hello Josh,

Could you please take a look other this patch?

THX
Attachment #8692967 - Flags: review?(jaas)
Blocks: coverity-analysis
Attachment #8692967 - Flags: review?(jaas) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3394473d2101
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.