Closed Bug 1192996 Opened 5 years ago Closed 5 years ago

Various serviceworker web-platform tests are permafailing on the Gecko 41 merge to Beta

Categories

(Core :: DOM: Service Workers, defect, blocker)

40 Branch
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Tracking Status
firefox41 --- disabled
firefox42 --- affected
firefox43 --- affected

People

(Reporter: RyanVM, Assigned: bkelly)

Details

Attachments

(2 files, 1 obsolete file)

Summary: Various serviceworker web-platform tests are permafailing on the Gecko 41 uplift to Beta → Various serviceworker web-platform tests are permafailing on the Gecko 41 merge to Beta
These just need the pref enabled in the dir-wide prefs.
Status: NEW → ASSIGNED
Claiming r+ on this since jgraham previously reviewed it for me on bug 1184967.
Attachment #8645979 - Flags: review+
Comment on attachment 8645979 [details] [diff] [review]
Enable service worker prefs for service worker wpt tests. r=jgraham

Approval Request Comment
[Feature/regressing bug #]: service worker wpt tests
[User impact if declined]: Tests fail without prefs enabled in release
[Describe test coverage new/current, TreeHerder]: WPT tests
[Risks and why]: Minimal
[String/UUID change made/needed]: None
Attachment #8645979 - Flags: approval-mozilla-beta?
Attachment #8645979 - Flags: approval-mozilla-aurora?
Seems there might still be an error in one of the tests on beta.  If we could handle that as a separate bug, that would be great.
Actually, I need to investigate these errors further.  I might need another pref.
Keywords: checkin-needed
Attachment #8645979 - Flags: approval-mozilla-beta?
Attachment #8645979 - Flags: approval-mozilla-aurora?
Comment on attachment 8645979 [details] [diff] [review]
Enable service worker prefs for service worker wpt tests. r=jgraham

There is something else broken in wpt on beta right now.  For example, I see tests like fetch-event-after-navigation-within-page.https.html trigger this DNS error page locally:

  about:neterror?e=dnsNotFound&u=https%3A//%25%28server%29s/selfsupport-dummy/&c=UTF-8&f=regular&d=Firefox%20can't%20find%20the%20server%20at%20%25%28server%29s

I don't have time to figure that out this evening in order to fix the tree.  I plan to just disable the wpt tests on beta.

James, do you have any idea why the page on beta would be getting the %(server) thing?
Attachment #8645979 - Attachment is obsolete: true
Flags: needinfo?(james)
This disables the tests in beta.  If we can figure out the issues perhaps we can re-enable later this week.

Wes, can you push this to the beta branch for me?
Flags: needinfo?(wkocher)
No, no idea off the top of my head. I mean there's clearly a string substitution that isn't happening in the harness, but how that can depend on the channel is a mystery.
Flags: needinfo?(james)
There are harness problems and it would be complicated to uplift.  So lets disable these tests by removing their manifest entries completely.  I plan to land this on beta for the current bustage and in aurora to prevent bustage on the next merge.
Fixed in beta.  I believe James fixed or is fixing the harness issues in central.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.