1192996 - Various serviceworker web-platform tests are permafailing on the Gecko 41 merge to Beta

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=451931&repo=mozilla-beta

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

These just need the pref enabled in the dir-wide prefs.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Enable service worker prefs for service worker wpt tests. r=jgraham

Claiming r+ on this since jgraham previously reviewed it for me on bug 1184967.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8645979 [details] [diff] [review]
Enable service worker prefs for service worker wpt tests. r=jgraham

Approval Request Comment
[Feature/regressing bug #]: service worker wpt tests
[User impact if declined]: Tests fail without prefs enabled in release
[Describe test coverage new/current, TreeHerder]: WPT tests
[Risks and why]: Minimal
[String/UUID change made/needed]: None

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Seems there might still be an error in one of the tests on beta.  If we could handle that as a separate bug, that would be great.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Actually, I need to investigate these errors further.  I might need another pref.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8645979 [details] [diff] [review]
Enable service worker prefs for service worker wpt tests. r=jgraham

There is something else broken in wpt on beta right now.  For example, I see tests like fetch-event-after-navigation-within-page.https.html trigger this DNS error page locally:

  about:neterror?e=dnsNotFound&u=https%3A//%25%28server%29s/selfsupport-dummy/&c=UTF-8&f=regular&d=Firefox%20can't%20find%20the%20server%20at%20%25%28server%29s

I don't have time to figure that out this evening in order to fix the tree.  I plan to just disable the wpt tests on beta.

James, do you have any idea why the page on beta would be getting the %(server) thing?

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Disable wpt service worker tests on BETA ONLY. r=testonly

This disables the tests in beta.  If we can figure out the issues perhaps we can re-enable later this week.

Wes, can you push this to the beta branch for me?

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ba2da490d03

Comment 9

[James Graham [:jgraham]]

No, no idea off the top of my head. I mean there's clearly a string substitution that isn't happening in the harness, but how that can depend on the channel is a mystery.

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Use empty manifest to disable wpt _mozilla tests due to harness bugs. r=testonly a=bustage

There are harness problems and it would be complicated to uplift.  So lets disable these tests by removing their manifest entries completely.  I plan to land this on beta for the current bustage and in aurora to prevent bustage on the next merge.

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

https://hg.mozilla.org/releases/mozilla-beta/rev/396989ed7b43

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

 https://hg.mozilla.org/releases/mozilla-aurora/rev/543a44fc6e0d

Comment 13

[Ben Kelly [:bkelly, not reviewing]]

Fixed in beta.  I believe James fixed or is fixing the harness issues in central.