Closed Bug 119301 Opened 23 years ago Closed 23 years ago

Implement nsIDOMXULMenuListElement on autocomplete widget

Categories

(SeaMonkey :: Autocomplete, defect, P3)

Product:
SeaMonkey
Component:
Autocomplete
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: aaronlev, Assigned: aaronlev)

References

Details

(Keywords: access, Whiteboard: seeking r=)

Attachments

(2 files)

This implements enough for accessibility
4.05 KB, patch
hewitt
: superreview+
Details | Diff | Splinter Review
patch with jag's fixes
4.04 KB, patch
jag+mozilla
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review 
The autocomplete widget is like an editable menulist.

It should support the nsIDOMXULMenuListElement interface
Should this be a XUL 1.0 blocker?
Keywords: access
OS: Windows 2000 → All
Hardware: PC → All
.
Component: XP Toolkit/Widgets: XUL → XP Apps: Autocomplete
QA Contact: jrgm → blaker
Joe, I think we can open a bug to finish the rest later.
Is this worthy?
-> I'll do the first part, what's needed for accessibility
Assignee: hewitt → aaronl
Priority: -- → P3
Whiteboard: seeking r=, sr=
Target Milestone: --- → mozilla0.9.9
Status: NEW → ASSIGNED
Comment on attachment 65211 [details] [diff] [review]
This implements enough for accessibility

Just change
return this.hasAttribute('open');

to return this.getAttribute("open") == "true";

and then sr=hewitt
Attachment #65211 - Flags: superreview+
Okay, hewitt's correction is fixed on my local tree.
Whiteboard: seeking r=, sr= → seeking r=

    
    

    
  
Comment on attachment 65583 [details] [diff] [review]
patch with jag's fixes

r=jag, carrying over sr=hewitt

        Attachment #65583 -
        Flags: superreview+

        Attachment #65583 -
        Flags: review+

    
    

    
  
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
  
Blocks: 70753
Product: Core → Mozilla Application Suite

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: