Closed Bug 1193018 Opened 4 years ago Closed 4 years ago

[Accessibility] Improve accessibility for non-natively-focusable controls.

Categories

(Firefox OS Graveyard :: Gaia, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Keywords: access)

Attachments

(5 files, 2 obsolete files)

Right now there are cases of elements that should be focusable (have correct roles etc) but are not universally focusable (no tabindex). They work because our screen reader handles such elements as if they are but it's not the case for other assistive technologies and especially accessibility evaluation tools. We need to add tabindex wherever necessary.
Attached file Gallery Github pull request. (obsolete) —
Attachment #8645961 - Flags: review?(dflanagan)
Attachment #8645961 - Attachment description: Github pull request. → Gallery Github pull request.
Attached file Music Github Pull Request. (obsolete) —
Attachment #8645965 - Flags: review?(dominickuo)
Attachment #8645961 - Attachment is obsolete: true
Attachment #8645961 - Flags: review?(dflanagan)
Attachment #8645965 - Attachment is obsolete: true
Attachment #8645965 - Flags: review?(dominickuo)
Attachment #8645960 - Flags: review?(dflanagan)
Attachment #8645962 - Flags: review?(dominickuo)
Attachment #8645966 - Flags: review?(timdream)
Attachment #8645966 - Flags: review?(timdream) → review+
Comment on attachment 8645962 [details] [review]
[gaia] yzen:bug-1193018-music > mozilla-b2g:master

The changes are trivial and no harm so looks good to me.
Attachment #8645962 - Flags: review?(dominickuo) → review+
Comment on attachment 8646392 [details] [review]
[gaia] yzen:bug-1193018-vertical-home-gaia-grid > mozilla-b2g:master

Another small fix for gaia-grid that affects a number of vertical homescreen tests.
Attachment #8646392 - Flags: review?(timdream)
Attachment #8646406 - Flags: review?(dflanagan)
Comment on attachment 8646392 [details] [review]
[gaia] yzen:bug-1193018-vertical-home-gaia-grid > mozilla-b2g:master

I think we should upstream the change in shared/elements/
Attachment #8646392 - Flags: review?(timdream) → review+
(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #12)
> Comment on attachment 8646392 [details] [review]
> [gaia] yzen:bug-1193018-vertical-home-gaia-grid > mozilla-b2g:master
> 
> I think we should upstream the change in shared/elements/

Yeah I was going to do that too, but could not find the component repository. Would you know where it is, Tim?
Flags: needinfo?(timdream)
(In reply to Yura Zenevich [:yzen] from comment #13)
> (In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to
> queue) from comment #12)
> > Comment on attachment 8646392 [details] [review]
> > [gaia] yzen:bug-1193018-vertical-home-gaia-grid > mozilla-b2g:master
> > 
> > I think we should upstream the change in shared/elements/
> 
> Yeah I was going to do that too, but could not find the component
> repository. Would you know where it is, Tim?

https://github.com/gaia-components

Ping :wilsonpage for detail.
Flags: needinfo?(timdream)
Depends on: 1194106
Hi David, let me know if I can forward this to someone else in case you're too busy atm.
Flags: needinfo?(dflanagan)
Attachment #8646406 - Flags: review?(dflanagan) → review?(rnicoletti)
Attachment #8645960 - Flags: review?(dflanagan) → review?(punamdahiya)
Flags: needinfo?(dflanagan)
Comment on attachment 8645960 [details] [review]
[gaia] yzen:bug-1193018-gallery > mozilla-b2g:master

Patch looks good on first glance, my only question is why do we need to comment delete image test in the patch?
Flags: needinfo?(yzenevich)
(In reply to Punam Dahiya from comment #17)
> Comment on attachment 8645960 [details] [review]
> [gaia] yzen:bug-1193018-gallery > mozilla-b2g:master
> 
> Patch looks good on first glance, my only question is why do we need to
> comment delete image test in the patch?

Ah, apologies, I did not clean it up after testing, should be all set now.
Flags: needinfo?(yzenevich) → needinfo?(punamdahiya)
Comment on attachment 8646406 [details] [review]
[gaia] yzen:bug-1193018-video > mozilla-b2g:master

Looks ok to me.
Attachment #8646406 - Flags: review?(rnicoletti) → review+
Comment on attachment 8645960 [details] [review]
[gaia] yzen:bug-1193018-gallery > mozilla-b2g:master

Hi Yura

Thanks for the updated patch. After adding tab index to thumbnail container element, a dotted border shows on selecting thumbnail. To replicate easily,
1) Click select button in footer
2) Tap on thumbnail, it will show dotted border along with blue outline on last selected thumbnail

This can be fixed by setting outline: none on containing div element where we are setting tab index 
https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/style/gallery.css#L266


I see a unit test failing but that's definitely unrelated to the changes in this patch. Thanks!
Flags: needinfo?(punamdahiya)
Attachment #8645960 - Flags: review?(punamdahiya) → review-
This seems to have introduced CSS outlines on all the affected elements. This patch should have come with `outline: 0` styling too.
Comment on attachment 8645960 [details] [review]
[gaia] yzen:bug-1193018-gallery > mozilla-b2g:master

Should be addressed now.
Attachment #8645960 - Flags: review- → review?(punamdahiya)
Comment on attachment 8645960 [details] [review]
[gaia] yzen:bug-1193018-gallery > mozilla-b2g:master

Thanks Yura, Patch looks good and has my r+.
Attachment #8645960 - Flags: review?(punamdahiya) → review+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1197718
You need to log in before you can comment on or make changes to this bug.