1193020 - [music] Add a search() function to the database backend

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Jim Porter (:squib)]

Search logic is a "backend" idea and we shouldn't expect the UI to handle the query-strings*. I have a patch to fix this, which will make things a little simpler for the NGA Music app.

* Granted, the query-strings are pretty basic right now.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jimporter:music-db-abstract > mozilla-b2g:master

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8645963 [details] [review]
[gaia] jimporter:music-db-abstract > mozilla-b2g:master

There are two commits here; the first one is just cleanup and is probably unnecessary if we're dropping the OGA Music app, but it might be worth landing just because it's less work to remove it. :)

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8645963 [details] [review]
[gaia] jimporter:music-db-abstract > mozilla-b2g:master

LGTM. Ship it!

Comment 5

[Jim Porter (:squib)]

Landed with some minor fixes: https://github.com/mozilla-b2g/gaia/commit/60489c1ff8c5d1633fc4837d4f8019623d4e1940

Comment 6

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in Bug 1192173 comment 0.

Actual results: Inputting/deleting some characters to search a song in Music app, it cleans up and shows the searching results normally, it doesn't flash "No music found" when the inputting character is matched with some songs. 
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150817150206
Gaia Revision          60489c1ff8c5d1633fc4837d4f8019623d4e1940
Gaia Date              2015-08-16 02:21:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9673c75864beafca2f6c8b117b98503128bf2e56
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150817.182933
Firmware Date          Mon Aug 17 18:29:45 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150818005621
Gaia Revision          60489c1ff8c5d1633fc4837d4f8019623d4e1940
Gaia Date              2015-08-16 02:21:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6ae3e9ff53b2bae8d95a90c9f25368fd81fa357e
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150818.003312
Firmware Date          Tue Aug 18 00:33:21 UTC 2015
Bootloader             s1

Comment 7

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp