loadQueuedTabs is called on the main thread

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios+)

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
1. That means we create the queue table, and the browser DB, on the main thread.
2. That might mean we're racing, causing crashes.
3. That also might mean we're harming startup performance on multi-core devices.


tracking? for those reasons.
(Assignee)

Comment 1

3 years ago
Created attachment 8646010 [details] [review]
Pull req.

Let's see who gets to this first.

Tested restore.
Attachment #8646010 - Flags: review?(sleroux)
Attachment #8646010 - Flags: review?(sarentz)
Attachment #8646010 - Flags: review?(bnicholson)
Comment on attachment 8646010 [details] [review]
Pull req.

LGTM
Attachment #8646010 - Flags: review?(bnicholson) → review+
(Assignee)

Updated

3 years ago
Attachment #8646010 - Flags: review?(sleroux)
Attachment #8646010 - Flags: review?(sarentz)
(Assignee)

Comment 3

3 years ago
a33d99c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
tracking-fxios: ? → +
You need to log in before you can comment on or make changes to this bug.