1193069 - Crash on update to Build 30

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Richard Newman [:rnewman]]

https://gist.github.com/sleroux/968b706df81ac45fb42a#file-testflight-crash

Storage!_TFFC7Storage12BrowserTable11updateTableFS0_FTCS_18SQLiteDBConnection4fromSi2toSi_SbU_FCS_5SDRowSS + 0x108
     fp = 0x000000016fdfc850    lr = 0x00000001005b11f4
     sp = 0x000000016fdfc840    pc = 0x00000001005c4c14
    Found by: previous frame's frame pointer

Comment 1

[Richard Newman [:rnewman]]

            let urls = db.executeQuery("SELECT DISTINCT url FROM \(TableHistory)", factory: { $0["url"] as! String })

versus

            "url TEXT UNIQUE, " +                 // May only be null for deleted records.

That looks like one possible culprit.

Comment 2

[Richard Newman [:rnewman]]

I can repro with a SIGABRT at that line with a similar stack if I null out a URL in the DB. The log shows

  Could not cast value of type '__NSCFNumber' (0x10cd8ccf0) to 'NSString' (0x10bebd8e0).

which is presumably a null -> 0 sqlite/SwiftData confusion.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Pull req.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8646082 [details] [review]
Pull req.

The code looks good. What scenario would we have a null url? Would this happen if we try restoring a saved 'home panel' tab?

Comment 5

[Richard Newman [:rnewman]]

This would happen if you have a deleted history item that hasn't yet synced to the server. There might be other root causes that I haven't yet identified.

Comment 6

[Richard Newman [:rnewman]]

b48f840