1193117 - Add exclusive mode to MediaEventSource to enable Move when possible

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

I found it useful to enable Move when there is only one listener. This allows us to pass event data which is only movable like nsAutoPtr.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

I just realized Move is an optional optimization, but not mandatory. MediaEventSource can't support a type which is not copyable.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

I find it quite a lot of work to support move-only types in exclusive mode. Spin bug 1194112 to handle that.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1193117. Add an exclusive mode to allow at most one listener.

Bug 1193117. Add an exclusive mode to allow at most one listener.

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8647879 [details]
MozReview Request: Bug 1193117. Add an exclusive mode to allow at most one listener.

https://reviewboard.mozilla.org/r/16077/#review14411

Ship It!

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39172e1b1480

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/39172e1b1480