1193197 - Server side logging: get rid of splitLogs and specifiers variables

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The code that is responsible for parsing HTTP headers looks unnecessary complex as it is splitted in two steps. It will be much easier if you combine both steps, i.e. building the concatenated string directly from one loop.

Also, this feature is already implemented in the webconsole. Couldn't we just pass the printf-like string as-is and let the existing console code do this work?
Or, couldn't we at least share the code?

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1168872#c21

Honza

Comment 2

[Florent Fayolle]

I take it.

Comment 3

[Florent Fayolle]

Attachment: 1193197.patch

Alex, here are the optimizations you asked for. Note that I plan to look for a way to expose the Console::processArguments function (C++ side) to avoid the code duplication (and therefore get rid of the format() function).

Florent

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8657562 [details] [diff] [review]
1193197.patch

Review of attachment 8657562 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Are you able to push to try?

Comment 6

[Florent Fayolle]

Yep. I just had to rebase a bit my work and recompile.

The try-push is here (in progress): https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a4d1966b360

Florent

Comment 7

[Florent Fayolle]

Asking for check-in after the try-push. Looks like there is no regression.

Florent

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6d3465f4aa24

Comment 9

[Nigel Babu [:nigelb]]

Please add the patch onto the bug if you've had to rebase it. It helps us sheriffs when we need to land checkin-needed bugs :)

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d3465f4aa24