Closed Bug 1193224 Opened 4 years ago Closed 4 years ago

Remove --tests-root-dir option

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jgraham, Unassigned)

References

Details

Attachments

(2 files)

This looks unused to me, although I could be missing something.
Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.
Attachment #8646446 - Flags: review?(ahalberstadt)
Attachment #8646446 - Flags: review?(ahalberstadt)
Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

https://reviewboard.mozilla.org/r/15761/#review14139

There's another occurrence in selftest.py, this will break the test.
Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.
Attachment #8646446 - Flags: review?(ahalberstadt)
Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

https://reviewboard.mozilla.org/r/15761/#review14697

Ship It!
Attachment #8646446 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.
Backed out for breaking Android 4.0 debug reftests
https://hg.mozilla.org/integration/mozilla-inbound/rev/d90bfbc8688a
https://hg.mozilla.org/mozilla-central/rev/46b3878338c2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
This broke 'make xpcshell-tests': https://dxr.mozilla.org/mozilla-central/source/testing/testsuite-targets.mk#290
Flags: needinfo?(james)
Is there a reason that you particularly need to use make here? As the file says it's deprecated in favour of the mach frontend.

In any case I imagine this will work if you just remove the --test-root-dir line from the makefile?
Flags: needinfo?(james)
(In reply to James Graham [:jgraham] from comment #15)
> Is there a reason that you particularly need to use make here? As the file
> says it's deprecated in favour of the mach frontend.

I noticed as it's still used in Instantbird's build.mk.

> In any case I imagine this will work if you just remove the --test-root-dir
> line from the makefile?

Yes, removing the now unsupported option here too should fix things.
Attached patch PatchSplinter Review
Attachment #8664762 - Flags: review?(ahalberstadt)
Comment on attachment 8664762 [details] [diff] [review]
Patch

Review of attachment 8664762 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8664762 - Flags: review?(ahalberstadt) → review+
Keywords: checkin-needed
Backed out for possibly causing asan/mulet test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=14582981&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/49a3d50e0068
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Guess this should remain resolved since the original patch is still landed.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
I don't see how those test failures could be related, as anything using 'make xpcshell-tests' would have been broken already before this patch landed. But I've pushed it to try to check.
Yeah, especially since it was causing mochitest failures. There were two patches backed out on suspicion of causing bustage, I think the other one was the likely cause.. but might as well wait for the try results to be safe.
Actually tests were still broken on that backout, so neither of the backed out patches is at fault. I'll re-check this in once I figure out what actually broke it. Sorry for the churn.
Flags: needinfo?(wkocher)
Flags: needinfo?(wkocher)
You need to log in before you can comment on or make changes to this bug.