1193224 - Remove --tests-root-dir option

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[James Graham [:jgraham]]

This looks unused to me, although I could be missing something.

Comment 1

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

https://reviewboard.mozilla.org/r/15761/#review14139

There's another occurrence in selftest.py, this will break the test.

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

https://reviewboard.mozilla.org/r/15761/#review14697

Ship It!

Comment 5

[James Graham [:jgraham]]

Comment on attachment 8646446 [details]
MozReview Request: Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Bug 1193224 - Remove vestigial --tests-root-dir option from xpcshell tests.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb035419fd9c

Comment 7

[Carsten Book [:Tomcat]]

sorry had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/5a8d86582839 since one of this changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=13953993&repo=mozilla-inbound

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1484fe1a38e6

Comment 9

[Nigel Babu [:nigelb]]

Had to back it out in https://hg.mozilla.org/integration/mozilla-inbound/rev/fa0a54cadfd0 for failures on Android 4.0 API11 reftests that look like this https://treeherder.mozilla.org/logviewer.html#?job_id=14037560&repo=mozilla-inbound

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cc19a8f1bb0

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for breaking Android 4.0 debug reftests
https://hg.mozilla.org/integration/mozilla-inbound/rev/d90bfbc8688a

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46b3878338c2

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46b3878338c2

Comment 14

[aleth [:aleth]]

This broke 'make xpcshell-tests': https://dxr.mozilla.org/mozilla-central/source/testing/testsuite-targets.mk#290

Comment 15

[James Graham [:jgraham]]

Is there a reason that you particularly need to use make here? As the file says it's deprecated in favour of the mach frontend.

In any case I imagine this will work if you just remove the --test-root-dir line from the makefile?

Comment 16

[aleth [:aleth]]

(In reply to James Graham [:jgraham] from comment #15)
> Is there a reason that you particularly need to use make here? As the file
> says it's deprecated in favour of the mach frontend.

I noticed as it's still used in Instantbird's build.mk.

> In any case I imagine this will work if you just remove the --test-root-dir
> line from the makefile?

Yes, removing the now unsupported option here too should fix things.

Comment 17

[aleth [:aleth]]

Attachment: Patch

Comment 18

[Andrew Halberstadt [:ahal]]

Comment on attachment 8664762 [details] [diff] [review]
Patch

Review of attachment 8664762 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3870c695f4f

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for possibly causing asan/mulet test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=14582981&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/49a3d50e0068

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Guess this should remain resolved since the original patch is still landed.

Comment 22

[aleth [:aleth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad765143f826

Comment 23

[aleth [:aleth]]

I don't see how those test failures could be related, as anything using 'make xpcshell-tests' would have been broken already before this patch landed. But I've pushed it to try to check.

Comment 24

[Andrew Halberstadt [:ahal]]

Yeah, especially since it was causing mochitest failures. There were two patches backed out on suspicion of causing bustage, I think the other one was the likely cause.. but might as well wait for the try results to be safe.

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Actually tests were still broken on that backout, so neither of the backed out patches is at fault. I'll re-check this in once I figure out what actually broke it. Sorry for the churn.

Comment 26

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5d2563ac0ae

Comment 27

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5d2563ac0ae