1193298 - Disallow implicit conversion to T* from RefPtr<T>&&

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Part 1 -- Avoid RefPtr in ternary operator

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Part 2 -- Use .get to convert from RefPtr to raw pointer

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Part 3 -- Delete RefPtr<T>::operator T*()&&

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8810c8f88634

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8646335 [details] [diff] [review]
Part 3 -- Delete RefPtr<T>::operator T*()&&

Review of attachment 8646335 [details] [diff] [review]:
-----------------------------------------------------------------

Man, unifying nsRefPtr and RefPtr can't come soon enough...

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b16d0820ac67
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a488cbda2a6
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2676b325b8a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b16d0820ac67
https://hg.mozilla.org/mozilla-central/rev/1a488cbda2a6
https://hg.mozilla.org/mozilla-central/rev/a2676b325b8a