1193392 - Unit test the new home screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Guillaume Marty [:gmarty]]

We agreed to add unit tests to the new homescreen after landing it.

Comment 1

[Guillaume Marty [:gmarty]]

Attachment: Github PR

There is a total of 64 unit tests for the 3 main JS files in the new homescreen.
The code coverage should be OK, though for some reason I can't get any figure from Blanket.

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8649327 [details] [review]
Github PR

It'd probably be diligent of me to give this another look over before r+ given the size of it and the number of comments, but this is good work. Certainly an r+ in spirit :) Few comments and nits to address.

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8649327 [details] [review]
Github PR

I fixed the nit and changes you pointed out. How does it look now?

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8649327 [details] [review]
Github PR

Couple of nits and one comment, but this is definitely more than good enough to ship, thanks and well done :)

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1193392-Unit-test-the-new-home-screen-2 > mozilla-b2g:master

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8650424 [details] [review]
[gaia] gmarty:Bug-1193392-Unit-test-the-new-home-screen-2 > mozilla-b2g:master

I had to open a new PR due to a bad commit. Can you move your r+ over this one, please?

Comment 7

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/pull/31441