Closed Bug 1193396 Opened 9 years ago Closed 9 years ago

Use JPEGs instead of PNGs for screenshots

Categories

(Firefox for iOS :: Browser, defect)

All
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: bnicholson, Assigned: bnicholson)

Details

(Keywords: perf)

Attachments

(1 file)

Since PNGs are a lossless image format, PNG screenshots can be significantly larger than JPEGs. Let's switch to JPEG to cut back on disk usage.
Some quick data points, with the same screenshots:

PNG:
1MB, 651ms
87kb, 320ms

JPEG:
108kb, 88ms
32kb, 51ms

Pretty huge data and perf wins.

Setting ui-review? since this does affect the screenshot quality for the tab zoom animation when selecting a tab. To test this, open some tabs, then close and reopen the browser. All restored screenshots in the tab tray will then be from JPEGs.
Attachment #8646440 - Flags: ui-review?(randersen)
Attachment #8646440 - Flags: ui-review?(dhenein)
Attachment #8646440 - Flags: review?(sleroux)
Attachment #8646440 - Flags: review?(sarentz)
Attachment #8646440 - Flags: review?(rnewman)
tracking-fxios: --- → ?
Keywords: perf
Comment on attachment 8646440 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/902

Code is fine by me.
Attachment #8646440 - Flags: review?(rnewman) → review+
Comment on attachment 8646440 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/902

Thanks for the quick review!
Attachment #8646440 - Flags: review?(sleroux)
Attachment #8646440 - Flags: review?(sarentz)
Attachment #8646440 - Flags: ui-review?(randersen) → ui-review+
Attachment #8646440 - Flags: ui-review?(dhenein)
https://github.com/mozilla/firefox-ios/commit/88911378fb6893cad0dea58b98bace1bb5fd32d3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: