Closed
Bug 1193396
Opened 10 years ago
Closed 10 years ago
Use JPEGs instead of PNGs for screenshots
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
(Keywords: perf)
Attachments
(1 file)
|
47 bytes,
text/x-github-pull-request
|
rnewman
:
review+
tecgirl
:
ui-review+
|
Details | Review |
Since PNGs are a lossless image format, PNG screenshots can be significantly larger than JPEGs. Let's switch to JPEG to cut back on disk usage.
|
Assignee | |
Comment 1•10 years ago
|
||
Some quick data points, with the same screenshots:
PNG:
1MB, 651ms
87kb, 320ms
JPEG:
108kb, 88ms
32kb, 51ms
Pretty huge data and perf wins.
Setting ui-review? since this does affect the screenshot quality for the tab zoom animation when selecting a tab. To test this, open some tabs, then close and reopen the browser. All restored screenshots in the tab tray will then be from JPEGs.
Attachment #8646440 -
Flags: ui-review?(randersen)
Attachment #8646440 -
Flags: ui-review?(dhenein)
Attachment #8646440 -
Flags: review?(sleroux)
Attachment #8646440 -
Flags: review?(sarentz)
Attachment #8646440 -
Flags: review?(rnewman)
|
||
Updated•10 years ago
|
tracking-fxios:
--- → ?
Keywords: perf
|
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8646440 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/902
Code is fine by me.
Attachment #8646440 -
Flags: review?(rnewman) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8646440 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/902
Thanks for the quick review!
Attachment #8646440 -
Flags: review?(sleroux)
Attachment #8646440 -
Flags: review?(sarentz)
|
||
Updated•10 years ago
|
Attachment #8646440 -
Flags: ui-review?(randersen) → ui-review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8646440 -
Flags: ui-review?(dhenein)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•