Closed Bug 1193462 Opened 5 years ago Closed 5 years ago
Tapping Sign in on Empty Sync panel should take you to the Sign in flow, not Settings first
As I understand it, since the flow is a webview is must be loaded this way and cannot be loaded from the Sync panel. If possible, the user should be taken straight to the Sign in flow within Settings, not left at Settings. Is there a way to do push them directly to the Sign in flow? They may see a short hop but they would end up in the right place and not have to tap it on their own.
I don't know of a good reason why we couldn't just take them straight into sign-in; we just haven't built it yet.
Hardware: Other → All
This is also true for the tour.
Attachment #8651960 - Flags: review?(bnicholson) → review+
I'm testing this now, particularly the case where you already have an account.
This is a no go. As it stands this PR takes you to a new Sign In page from the tour when you already have an account, and that will cause havoc. At the very least it should take you to the manage page -- the one you get to when you tap your account name in Settings. Alternatively we should consider taking signed-in users to Settings, where they'll be able to see the state of their account, tap Sync Now, or just head back to the browser. Other than that, this looks good.
Comment on attachment 8651960 [details] [review] https://github.com/mozilla/firefox-ios/pull/974 Sounds like rnewman is more familiar with this flow than I am, so passing review to him.
Attachment #8651960 - Flags: review+ → review?(rnewman)
Comment on attachment 8651960 [details] [review] https://github.com/mozilla/firefox-ios/pull/974 I've updated the patch to include redirecting the user to the settings page from the signin button on the tour if the user is already signed in. Also added PR comment fixes: https://github.com/mozilla/firefox-ios/commit/a772ee986ed7d7d14461d1db5b046e3dcededdb3
Attachment #8651960 - Flags: ui-review?(randersen) → ui-review+
Attachment #8651960 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.