Closed Bug 1193569 Opened 9 years ago Closed 9 years ago

align icon and text in Hello panel tabs

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
2

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Iteration:
43.3 - Sep 21

People

(Reporter: dmosedale, Assigned: crafuse)

References

Details

(Whiteboard: [visual refresh])

User Story

As a user, I see the icons aligned next to the text in the dropdown panel tabs, so that things looks visually crisp, as per the mocks.

Attachments

(4 files)

Fix icon/text in Hello dropdown panel tabs, paired with dmose, r=dmose/chris.rafuse
1012 bytes, patch
dmosedale
: review+
Details | Diff | Splinter Review
icon Vert Align Fix Compare
31.01 KB, image/png
sevaan
: ui-review-
Details
icon Original Showcase
27.59 KB, image/png
Details
icon Fix Applied Showcase
27.37 KB, image/png
Details
Some cleanup of this CSS happened in bug 1183619, but it still wasn't aligned closely enough to the mocks.
Flags: firefox-backlog+
Comment on attachment 8646669 [details] [diff] [review] Fix icon/text in Hello dropdown panel tabs, paired with dmose, r=dmose/chris.rafuse r=dmose/chris.rafuse since as we paired this together. Chris, if you could attach a screenshot of the panel as it looks in your build and request ui-review? of :vicky, that would be great. Thanks!
Attachment #8646669 - Flags: review?(dmose) → review+
Rank: 17
Flags: qe-verify+
Priority: -- → P1
Iteration: 43.1 - Aug 24 → 43.2 - Sep 7
Iteration: 43.2 - Sep 7 → 43.3 - Sep 21
Here is comparison of tab icons alignments.
Attachment #8659623 - Flags: ui-review?(sfranks)
Attached image icon Original Showcase —
Comment on attachment 8659623 [details] icon Vert Align Fix Compare Was this an issue that was brought up? I feel like the alignment is better in the original (middle aligned, as oppose to bottom)
Attachment #8659623 - Flags: ui-review?(sfranks) → ui-review-
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: