desktop l10n releases require 'export' in 'make config'

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jlund, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
similar to https://bugzil.la/1169937

we are hitting this now because this export requirement was in aurora and has uplifted to beta
(Reporter)

Comment 1

3 years ago
Created attachment 8646761 [details] [diff] [review]
150811_1193620_add_export_to_release_beta_l10n_make_config.patch

this will have to be patched if successful to remove beta specific stuff. I have the beta check in so I, hopefully, don't mess with current 40.0.1 release build in flight since this code is shared.

also note, this should fix TB too (or at least affect TB)
Attachment #8646761 - Flags: review?(nthomas)
Attachment #8646761 - Flags: review?(nthomas) → review+
(Reporter)

Comment 2

3 years ago
Comment on attachment 8646761 [details] [diff] [review]
150811_1193620_add_export_to_release_beta_l10n_make_config.patch

thanks: https://hg.mozilla.org/build/tools/rev/44d23de5f9a0

also moved tags of 41 to accept this new rev
Attachment #8646761 - Flags: checked-in+
You had a plan for how to handle this when 41.0 release rolls around ?
(Reporter)

Comment 4

3 years ago
Comment on attachment 8646761 [details] [diff] [review]
150811_1193620_add_export_to_release_beta_l10n_make_config.patch

Review of attachment 8646761 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/python/build/l10n.py
@@ +91,5 @@
>                      cwd=path.join(sourceRepoName, objdir, path.dirname(dir)),
>                      env=env)
>          else:
> +            target = []
> +            if path.basename(dir) == 'config' and sourceRepoName.endswith('mozilla-beta'):

I *think* we can simply remove ` and sourceRepoName.endswith('mozilla-beta')`

the question is whether we can do that now which would effect any 40 related chemspills.
(Reporter)

Comment 5

3 years ago
Created attachment 8653772 [details] [diff] [review]
150827_1193620_l10n_desk_requires_export_in_make-comm-beta-fix_tools.patch

shrinking suffix to allow for comm-beta
Attachment #8653772 - Flags: review?(nthomas)
Attachment #8653772 - Flags: review?(nthomas) → review+
(Reporter)

Comment 6

3 years ago
Comment on attachment 8653772 [details] [diff] [review]
150827_1193620_l10n_desk_requires_export_in_make-comm-beta-fix_tools.patch

Review of attachment 8653772 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, checked in and updated desktop ff beta5 tags
Attachment #8653772 - Flags: checked-in+
(Reporter)

Comment 7

3 years ago
(In reply to Jordan Lund (:jlund) from comment #6)
> Comment on attachment 8653772 [details] [diff] [review]
> 150827_1193620_l10n_desk_requires_export_in_make-comm-beta-fix_tools.patch
> 
> Review of attachment 8653772 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> thanks, checked in and updated desktop ff beta5 tags

this time, I updated the tb beta1 tags (the ones I should have done):
https://hg.mozilla.org/build/tools/rev/ee7f685c5ebb
(Reporter)

Updated

3 years ago
Blocks: 1190766
(Reporter)

Comment 8

3 years ago
Created attachment 8660499 [details] [diff] [review]
150913_1193620_remove_beta_logic_from_make_export-tools.patch

time to land. uplift is tomorrow.
Attachment #8660499 - Flags: review?(nthomas)
Comment on attachment 8660499 [details] [diff] [review]
150913_1193620_remove_beta_logic_from_make_export-tools.patch

I'll just take this for a spin on mozilla-esr38 ...
Comment on attachment 8660499 [details] [diff] [review]
150913_1193620_remove_beta_logic_from_make_export-tools.patch

A Thunderbird l10n build based on comm-esr38/mozilla-esr38 was green this patch. When you land, please update the comment to remove the reference to 'beta'.
Attachment #8660499 - Flags: review?(nthomas) → review+
(Reporter)

Updated

3 years ago
Summary: desktop l10n beta releases require 'export' in 'make config' → desktop l10n releases require 'export' in 'make config'
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.