Closed Bug 1193747 Opened 6 years ago Closed 5 years ago

Don't log "The object cannot be linked to the inspector without a toolbox" message in the browser console

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: pbro, Assigned: jryans)

Details

Attachments

(1 file)

The console can log DOM nodes. And when it does, it generates a nice preview of the node that:
- is syntax highlighted
- displays the highlighter in the page when you hover over it
- has an inspector icon next to it that, when clicked, selects that node in the inspector

The last 2 features require the particular instance of the console that logged the node to be part of a complete toolbox that has an inspector panel.

Unfortunately if you use the Browser Console panel, there's no toolbox around it, so there's no inspector panel that can be used.
That's fine, you just can't select the node or highlight it in the page, but the code throws an error that therefore appears in the browser console too. So every DOM node logged gets followed by the error:
"The object cannot be linked to the inspector without a toolbox"

Relevant code is in:
/browser/devtools/webconsole/console-output.js
in the function |linkToInspector|

    // Checking the presence of a toolbox
    let target = this.message.output.toolboxTarget;
    this.toolbox = gDevTools.getToolbox(target);
    if (!this.toolbox) {
      throw new Error("The object cannot be linked to the inspector without a " +
        "toolbox");
    }
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8754539 [details]
MozReview Request: Bug 1193747 - Remove link to inspector error in Browser Console. r=pbro

https://reviewboard.mozilla.org/r/54022/#review51158
Attachment #8754539 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/6d7c8499b6fc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.