1193755 - [Regression] Transition to URL edit mode stretches url label

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect)

Description

[Darrin Henein [:darrin]]

Attachment: stretchy-url.mov

See attached video. This looks pretty bad.

Comment 1

[Richard Newman [:rnewman]]

Expected: slide; no stretch, no scale.

Comment 2

[Stephan Leroux [:sleroux]]

I'll see if this can be a quick win

Comment 3

[Bryan Munar (:bkmunar)]

WAIT whoa i think my fix fixes this too

Comment 4

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8647101 [details] [review]
PR

Haven't tried this out yet, but left some comments in the PR.

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8647101 [details] [review]
PR

I don't think this fixes the stretching of the URL text or the alpha fade. 

Whenever we enter editing mode, the text looks to be stretched and the buttons disappear instead of animations out to the left.

Whenever we exit editing mode, the buttons appear right away on top of the text field

These were taking in landscape on the iPhone 6 simulator.

I'm not sure what the best approach is given we want to do an RC on Friday. I feel like modifying a bunch of the constraints might be risky. Let's have a discussion about this tomorrow @ triage.

Comment 7

[Stephan Leroux [:sleroux]]

Attachment: Enter editing

Comment 8

[Stephan Leroux [:sleroux]]

Attachment: Exiting editing

Comment 9

[Darrin Henein [:darrin]]

Comment on attachment 8647101 [details] [review]
PR

This is the same patch as https://bugzilla.mozilla.org/show_bug.cgi?id=1190999 so same comments apply.

Comment 10

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/948

Comment 11

[Darrin Henein [:darrin]]

Comment on attachment 8649380 [details] [review]
https://github.com/mozilla/firefox-ios/pull/948

Now we're talkin'! Looks great, thanks.

Comment 12

[Stephan Leroux [:sleroux]]

I found an issue with the text stretch PR - because I moved the setting of the text inside the dispatch_async method, there was a bug where when you switch tabs, and you go to edit the url, you see the old url for a moment before the new one comes in. Added an update for it here so we can preserve the same behaviour for the pasted case: https://github.com/mozilla/firefox-ios/commit/ac06df4fa486fe5ee304465ad670c873a45dd782

Comment 13

[Stephan Leroux [:sleroux]]

Merged