Closed Bug 1193755 Opened 5 years ago Closed 5 years ago
[Regression] Transition to URL edit mode stretches url label
326.87 KB, video/quicktime
638.47 KB, image/png
312.16 KB, image/png
47 bytes, text/x-github-pull-request
|Details | Review|
See attached video. This looks pretty bad.
Expected: slide; no stretch, no scale.
I'll see if this can be a quick win
WAIT whoa i think my fix fixes this too
Comment on attachment 8647101 [details] [review] PR Haven't tried this out yet, but left some comments in the PR.
Attachment #8647101 - Flags: review?(bnicholson) → feedback+
Comment on attachment 8647101 [details] [review] PR I don't think this fixes the stretching of the URL text or the alpha fade. Whenever we enter editing mode, the text looks to be stretched and the buttons disappear instead of animations out to the left. Whenever we exit editing mode, the buttons appear right away on top of the text field These were taking in landscape on the iPhone 6 simulator. I'm not sure what the best approach is given we want to do an RC on Friday. I feel like modifying a bunch of the constraints might be risky. Let's have a discussion about this tomorrow @ triage.
Attachment #8647101 - Flags: review?(sleroux) → review-
Attachment #8647226 - Attachment description: Editing editing → Exiting editing
Comment on attachment 8647101 [details] [review] PR This is the same patch as https://bugzilla.mozilla.org/show_bug.cgi?id=1190999 so same comments apply.
Attachment #8647101 - Flags: ui-review?(dhenein) → ui-review-
Attachment #8647101 - Attachment is obsolete: true
Comment on attachment 8649380 [details] [review] https://github.com/mozilla/firefox-ios/pull/948 Now we're talkin'! Looks great, thanks.
Attachment #8649380 - Flags: ui-review?(dhenein) → ui-review+
Attachment #8649380 - Flags: review?(bnicholson) → review+
I found an issue with the text stretch PR - because I moved the setting of the text inside the dispatch_async method, there was a bug where when you switch tabs, and you go to edit the url, you see the old url for a moment before the new one comes in. Added an update for it here so we can preserve the same behaviour for the pasted case: https://github.com/mozilla/firefox-ios/commit/ac06df4fa486fe5ee304465ad670c873a45dd782
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.