Closed Bug 1193782 Opened 5 years ago Closed 5 years ago

Tab count indicator can still get into a state showing 0

Categories

(Firefox for iOS :: General, defect)

ARM
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: aaronmt, Assigned: sleroux)

Details

Attachments

(2 files)

Trying to re-trace STR
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Just to clarify, is the issue that we didn't restore tabs or that it shows 0 instead of 1?
Flags: needinfo?(aaron.train)
For me the issue is that it's showing 0 when we clearly have about:home open :)
Attachment #8647027 - Flags: review?(bnicholson)
Attachment #8647027 - Flags: review?(rnewman)
Comment on attachment 8647027 [details] [review]
https://github.com/mozilla/firefox-ios/pull/913

Thanks for the detailed explanation. Looks good!
Attachment #8647027 - Flags: review?(bnicholson) → review+
Although I am curious...I wonder what's causing this to happen? If tabManager.restoreTabs() restores 0 tabs, that means the last session was lost somehow, right?
Potentially - we did see this when upgrading some apps from testflight 31-32. I was able to reproduce it without doing an upgrade though so not sure if that's the only reason.
Comment on attachment 8647027 [details] [review]
https://github.com/mozilla/firefox-ios/pull/913

rnewman said to ship it in IRC - marking as reviewed.
Attachment #8647027 - Flags: review?(rnewman) → review+
Merged
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: needinfo?(aaron.train)
You need to log in before you can comment on or make changes to this bug.