1193849 - Bugs with "Learn More" link for Mixed Content Blocker in Control Center

Status: VERIFIED FIXED

(Firefox :: Security, defect, P1)

Description

[Tanvi Vyas[:tanvi]]

The enable protection page is missing it's Learn More link.

The disable protection page has the Learn More link in line with the other text, when I think it is supposed to be on a line of it's own.

(The page also needs updating, but I think that is in another bug? https://support.mozilla.org/en-US/kb/how-does-content-isnt-secure-affect-my-safety?as=u&utm_source=inproduct)

We should see if we can uplift the fixes to FF 42.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Tanvi Vyas [:tanvi] from comment #0)
> The enable protection page is missing it's Learn More link.

Yeah, the mockups didn't have them. I thought it was explicitly left out because we expect people to read before disabling MCB :) Quite easy to add one though if we want that.

> The disable protection page has the Learn More link in line with the other
> text, when I think it is supposed to be on a line of it's own.

It's an inline element, if it fits on the line then it won't have one of its own. If it doesn't it will wrap around.

> (The page also needs updating, but I think that is in another bug?
> https://support.mozilla.org/en-US/kb/how-does-content-isnt-secure-affect-my-
> safety?as=u&utm_source=inproduct)

Yes.

> We should see if we can uplift the fixes to FF 42.

Shouldn't be a problem.

Comment 2

[Tanvi Vyas[:tanvi]]

Is this possible to do for the 42 timeline?  Should be pretty easy and would be nice if we could get it in before aurora/42 because beta/42 on September 22nd.  I'm not sure this counts as post v1, since the learn more link existed before tracking protection v1.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1193849-Show-Learn-more-link-in-security-subview.patch

Added the "learn more" link to the security subview when mixed content blocking was disabled by the user. The links remain inline elements, they will wrap around as needed but will otherwise be on the same line as the owning paragraph. (That was how it was designed and what the mockups showed.)

Comment 4

[Tanvi Vyas[:tanvi]]

Comment on attachment 8664798 [details] [diff] [review]
0001-Bug-1193849-Show-Learn-more-link-in-security-subview.patch

Thanks Tim!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c096530a4b4b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c096530a4b4b

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8664798 [details] [diff] [review]
0001-Bug-1193849-Show-Learn-more-link-in-security-subview.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Missing "learn more" link when opening the control center after disabling mixed content blocking.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Very low risk
[String/UUID change made/needed]: None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8664798 [details] [diff] [review]
0001-Bug-1193849-Show-Learn-more-link-in-security-subview.patch

Polish of a new feature, taking it. Should be in 42 beta 3.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f84537028ef2

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d402ca7286f0

Comment 11

[Petruta Horea [:phorea]]

Reproduced using Firefox 42 beta 2 with the following pages:
https://people.mozilla.org/~tvyas/mixedcontent.html
https://people.mozilla.org/~tvyas/mixedboth.html

Verified as fixed using Firefox 42 beta 5, Developer Edition 43.0a2 and Nightly 44.0a1 2015-10-09 under Win 7 64-bit and Mac OS X 10.9.