Address Book: 'Get Map' button should open NEW Browser TAB to show map

NEW
Unassigned

Status

--
minor
3 years ago
2 years ago

People

(Reporter: mike_banach, Unassigned)

Tracking

SeaMonkey 2.33 Branch

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33.1
Build ID: 20150321194901

Steps to reproduce:

Browsing list of contacts in SeaMonkey 2.33.1.  When a contact has a physical address included a "Get Map" button appears on right side of lower panel.  I clicked that button.


Actual results:

My current browser window was used to display the map, resulting in that window moving off of the URL it was displaying.


Expected results:

A new window should have been spawned for the map so that existing browser windows were unaffected.

Comment 1

3 years ago
REPRODUCIBLE with  SeaMonkey en-US 2.39a1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0 from official download area)  Gecko/20100101  Firefox/42.0  Build 20150806070100  (Classic Theme) on German WIN7 64bit.

a) Did that ever work better? I did not test, but I doubt.
b) I did not find a DUP in <https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs1193872&sharer_id=41036&list_id=12470239>
c) Might be a MailCore issue, I will test thunderbird, soon
d) Seems more important than an enhancement request, if Map opens in a 
   browser tab concerning form fields, edit areas and similar it is not sure
   whether a simple [back] will bring back all contents.
e) Minor for now because I doubt that that issue really causes problems for
   many users.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: SeaMonkey: Address Book: Get Map button should spawn new window → Address Book: 'Get Map' button should open Map in new Browser TAB

Comment 2

3 years ago
Clicking on the button calls MapIt() which calls openTopWin()

function MapIt(id)
{
  var button = document.getElementById(id);
  openTopWin(button.getAttribute('url'));
}

Instead it should call openNewTabOrWindow()

function MapIt(id)
{
  var button = document.getElementById(id);
  openNewTabOrWindow(null, button.getAttribute('url'), null);
}
Mentor: iann_bugzilla, philip.chee
Whiteboard: [good first bug][lang=js]

Comment 3

3 years ago
This will be fixed in Bug 531285 (Use OpenStreetmap for maps (even allow the user to choose from list of map services))
Mentor: iann_bugzilla, philip.chee
Depends on: 531285
Whiteboard: [good first bug][lang=js]

Comment 4

3 years ago
I don't see that change in my patch there. It now uses openLinkWithUrl() which calls OpenURLWithHistory() in TB or openAsExternal() in SM.

Comment 5

3 years ago
(In reply to :aceman from comment #4)
> I don't see that change in my patch there. It now uses openLinkWithUrl()
> which calls OpenURLWithHistory() in TB or openAsExternal() in SM.

Yes, you refactored the code, so the above comment does not hold any more. In any case your fix in Bug 531285 will fix this problem in another way.
(Reporter)

Comment 6

2 years ago
Today I noticed the same effect occurs when clicking the "Go to the SeaMonkey home page" icon (link) at the top right of the mail email screen.  The current browser tab goes to http://www.seamonkey-project.org/ rather than a new tab opening.

Updated

2 years ago
Summary: Address Book: 'Get Map' button should open Map in new Browser TAB → Address Book: 'Get Map' button should open NEW Browser TAB to show map
You need to log in before you can comment on or make changes to this bug.