1193897 - upload.py shouldn't need to convert windows->msys paths

Status: NEW

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1118778#c9 we should investigate and probably remove the WindowsPathToMsysPath function from build/upload.py, as it may no longer be necessary.

Comment 1

[Mike Hommey [:glandium]]

Note the prerequisite would be buildbot not setting the variable with a tilde in it.

Comment 2

[(not currently active) Ted Mielczarek]

I can't remember exactly what the problem was, but I know that if you have environment variables that represent unixy paths, and you launch Python by way of MSYS bash, MSYS will helpfully translate the paths to local Windows paths for you. Shouldn't be hard to stick some prints in there and test on try.

Comment 3

[Michael Shal [:mshal]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> I can't remember exactly what the problem was, but I know that if you have
> environment variables that represent unixy paths, and you launch Python by
> way of MSYS bash, MSYS will helpfully translate the paths to local Windows
> paths for you. Shouldn't be hard to stick some prints in there and test on
> try.

One odd thing I discovered in bug 1118778 is that 'make upload' does some path conversion, while 'make upload | tee file.txt' doesn't do the path conversion, and needs the WindowsPathToMsysPath function. I guess this has to do with make finding the '|' character and launching the subprocess differently (the construct_command_argv_internal function in make's job.c), though I tried comparing the two with 'make -d' and didn't see anything obvious.