Closed
Bug 119398
Opened 23 years ago
Closed 23 years ago
DeviceContextImpl does not correctly check for errors
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: roland.mainz, Assigned: roland.mainz)
Details
Attachments
(1 file, 1 obsolete file)
|
10.39 KB,
patch
|
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
|DeviceContextImpl| does not correctly check for errors in some cases ...
|
Assignee | |
Updated•23 years ago
|
Severity: normal → critical
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
|
|
Assignee | |
Comment 2•23 years ago
|
||
|
|
Assignee | |
Comment 3•23 years ago
|
||
Who wants to r=/sr= this patch ? :)
|
||
Comment 4•23 years ago
|
||
Comment on attachment 64455 [details] [diff] [review]
Patch for 2002-01-07-08-trunk
sr=sfraser
I'd be quite happy if you change the "nsFoo :: Bar" to "nsFoo::Bar" too.
Attachment #64455 -
Flags: superreview+
|
|
Assignee | |
Comment 5•23 years ago
|
||
Attachment #64455 -
Attachment is obsolete: true
|
|
||
Comment 6•23 years ago
|
||
Comment on attachment 64458 [details] [diff] [review]
Better patch for smfr's comment
sr=sfraser
Attachment #64458 -
Flags: superreview+
Comment on attachment 64458 [details] [diff] [review]
Better patch for smfr's comment
iirc brendan et al don't like people using NS_IMETHOD foo (int &bar), foo(b);
and instead request that you do NS_IMETHOD foo (int *bar), foo(&b);
ignore that, checked in w/ my r=
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•