1193992 - Compress the fxa theme images

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Edouard Oger [:eoger]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1149721#c40.

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1193992.patch

Comment 2

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Comment on attachment 8647192 [details] [diff] [review]
bug-1193992.patch

I've no idea how to review this, nor if the optimization has decreased the quality.  Ryan, are you able to help here? Either to ensure the quality of the images remains acceptable, or to perform your own optimizations?

Comment 3

[Edouard Oger [:eoger]]

For information, I used the "lossless" setting of kraken.io, so we should be OK!

Comment 4

[Ryan Feeley [:rfeeley]]

I use image optimizers all the time (usually ImageOptim which runs a bunch of command line tools). As long as Edouard tests them on dark backgrounds to make sure the alpha hasn't been messed with, I'm sure they're fine.

Comment 5

[Ryan Feeley [:rfeeley]]

Comment on attachment 8647192 [details] [diff] [review]
bug-1193992.patch

Not sure how to get these files.

Comment 6

[Edouard Oger [:eoger]]

Verified the images on a red background, alpha channel is OK.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2ae3cb6c911b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ae3cb6c911b