119400 - Filenames shorted too much in Customize Part 1 page.

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-Wizard, defect, P3)

Description

[Steve Meredith (gone)]

Not too serious, but a pet-peeve of mine.

In the Customize the Browser Part 1 page of the wizard, the paths displayed in
the window for Animated and Static GIF's use ... in the directory when there is
actually plenty of space to show the whole path. For example, the path is
displayed as D:\...gs\Default\Workspace\AnimLogo\animlogo32.gif. There is pleny
of space to the right of the filename--there is no reason to shorten the path
name so much.

Comment 1

[Rob Jaworski]

cckrtm per triage.  We love ya, Steve.

Comment 2

[Rob Jaworski]

cckrtm+

Comment 3

[Shruti Vasudevan]

Reassigning.

Comment 4

[Mitch Faatz]

Attachment: dynamic text boxes enlarged, trim function set to a better length

Comment 5

[Steve Meredith (gone)]

r=smeredith

Comment 6

[Mitch Faatz]

Checked in changes described in attached patch

Comment 7

[Shruti Vasudevan]

Has this patch been verified with all other widgets that use GetTrimFile. For
example, do the paths for sidebar and bookmarks appear correct on the wizard
screen after applying the patch? I think the length '78' is too long for the
other widget paths. The length 47 is best suited for most widget paths, we have
to consider the path for animated and static gifs as special cases and provide a
different path length for only these 2 specific paths. It may not be a good idea
to change the length from 47 to 78 for all the dynamic text paths.

Comment 8

[Mitch Faatz]

I must have been smoking crack that day, I was sure I had grepped the other ini
files for existence of other DynamicText widgets and didn't find any.  Let me
re-evaluate this...

Comment 9

[Mitch Faatz]

Attachment: Okay, so it's more involved. Added widget value URLDisplayLength and code to pass that to the trim function, and updated all the DynamicText widgets to include their correct values.

Comment 10

[Shruti Vasudevan]

r=shrutiv

Comment 11

[Mitch Faatz]

Applied changes described in attachment 
http://bugzilla.mozilla.org/attachment.cgi?id=88001&action=view

Comment 12

[blee]

Verified fixed in 6/19 bld.