1194021 - smoothing out panel opening jank & investigate dropping possibly unnecessary resize code

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

There's an odd flicker while the panel content is loading which causes it to resize into it's final size in a janky, non-instantaneous way.

Mark points out in https://bugzilla.mozilla.org/show_bug.cgi?id=1192372#c2 that we may be able to just specify things in the XUL chrome code and possibly even get rid of the dynamic resizing code for less possibile maintainenance.

Note, however, that we'll need to accomodate at least two heights: the standard height of the panel, as well as the height of the new FTU experience, which is shorter.

This could happen by specifying explicit sizes to this.PanelFrame.showPopup inside of openCallPanel, currently at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-loop.js#156, though we'd have to check whether we were opening into the FTU or not.

Comment 1

[Mark Banner (:standard8)]

Vicky/Sevaan, would it be possible to size the FTU panel to 410px height so that it is the same as the rest of the Hello panel? It would then be simpler to implement this bug.

Comment 2

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #1)
> Vicky/Sevaan, would it be possible to size the FTU panel to 410px height so
> that it is the same as the rest of the Hello panel? It would then be simpler
> to implement this bug.

This time with need-info

Comment 3

[Victoria Gerchinhoren [:vicky]]

(In reply to Mark Banner (:standard8) from comment #2)
> (In reply to Mark Banner (:standard8) from comment #1)
> > Vicky/Sevaan, would it be possible to size the FTU panel to 410px height so
> > that it is the same as the rest of the Hello panel? It would then be simpler
> > to implement this bug.
> 
> This time with need-info

Sure, if it helps having a smoother transition between states. The update is reflected in the main mockup. Bare in mind that bottom portion of the already implemented design remains the same, only enlarge the upper area and set logo and copy in the middle.

Thanks!

Comment 4

[:shell escalante]

want to check out after visual refresh has landed to see how bad.

Comment 5

[Mark Banner (:standard8)]

Attachment: Fix the size of the loop panel, as we want a fixed size and don't want the dynamic resizer.

Turns out its very easy to fix the size of the panel for Loop. We might want this for bug 1192372, but attaching here for now anyway.

Comment 6

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #5)
> Created attachment 8654188 [details] [diff] [review]
> Fix the size of the loop panel, as we want a fixed size and don't want the
> dynamic resizer.
> 
> Turns out its very easy to fix the size of the panel for Loop. We might want
> this for bug 1192372, but attaching here for now anyway.

Note: this also turns off the dynamic resizer.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

With luck, 1192372 will have fixed this, but it's not in the 9/9 nightly, from what I can see, so we should take a look at it tomorrow before closing this out.

Comment 8

[:shell escalante]

fixed by bug 1192372