1194042 - Implement a global cut-or-copied state for text selection dialog across apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

In app_text_selection_dialog.js, we have one text selection dialog per app. We need to have a global cut-or-copied state instead of [1]. Otherwise the current app will not aware the cut-or-copied had been performed on other apps.

[1] https://github.com/mozilla-b2g/gaia/blob/474784fc494519a0fab866407c0215aacf984ed9/apps/system/js/app_text_selection_dialog.js#L19

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] aethanyc:1194042 > mozilla-b2g:master

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8647317 [details] [review]
[gaia] aethanyc:1194042 > mozilla-b2g:master

I've left a few comments on GitHub on what I think we should do to make the global state more transparent to callers. I hope it's clear enough. Do discuss with me in person if there is any question on this.

Thank you for taking care of this part of Gaia!

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8647317 [details] [review]
[gaia] aethanyc:1194042 > mozilla-b2g:master

Tim, I've updated the patch based on your comments on Github. Please review that again.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8647317 [details] [review]
[gaia] aethanyc:1194042 > mozilla-b2g:master

Please do what I said at 

https://github.com/mozilla-b2g/gaia/pull/31338#discussion_r36956622

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8647317 [details] [review]
[gaia] aethanyc:1194042 > mozilla-b2g:master

Discussed offline and r+ the next patch on his screen :)

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Tim, thank you for your review and guidance.

I've updated the PR to address comment #4, and the try result look good.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/bd4a67998e9e82e2f113cd4bdc994afddcaf2e10