Closed
Bug 1194042
Opened 9 years ago
Closed 9 years ago
Implement a global cut-or-copied state for text selection dialog across apps
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S6 (04Sep)
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file)
In app_text_selection_dialog.js, we have one text selection dialog per app. We need to have a global cut-or-copied state instead of [1]. Otherwise the current app will not aware the cut-or-copied had been performed on other apps. [1] https://github.com/mozilla-b2g/gaia/blob/474784fc494519a0fab866407c0215aacf984ed9/apps/system/js/app_text_selection_dialog.js#L19
Assignee | ||
Updated•9 years ago
|
Summary: Fix → Implement a global cut-or-copied state for text selection dialog across apps
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8647317 -
Flags: review?(timdream)
Comment 2•9 years ago
|
||
Comment on attachment 8647317 [details] [review] [gaia] aethanyc:1194042 > mozilla-b2g:master I've left a few comments on GitHub on what I think we should do to make the global state more transparent to callers. I hope it's clear enough. Do discuss with me in person if there is any question on this. Thank you for taking care of this part of Gaia!
Attachment #8647317 -
Flags: review?(timdream) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8647317 [details] [review] [gaia] aethanyc:1194042 > mozilla-b2g:master Tim, I've updated the patch based on your comments on Github. Please review that again.
Attachment #8647317 -
Flags: review?(timdream)
Comment 4•9 years ago
|
||
Comment on attachment 8647317 [details] [review] [gaia] aethanyc:1194042 > mozilla-b2g:master Please do what I said at https://github.com/mozilla-b2g/gaia/pull/31338#discussion_r36956622
Attachment #8647317 -
Flags: review?(timdream)
Comment 5•9 years ago
|
||
Comment on attachment 8647317 [details] [review] [gaia] aethanyc:1194042 > mozilla-b2g:master Discussed offline and r+ the next patch on his screen :)
Attachment #8647317 -
Flags: review+
Assignee | ||
Comment 6•9 years ago
|
||
Tim, thank you for your review and guidance. I've updated the PR to address comment #4, and the try result look good.
Keywords: checkin-needed
Comment 7•9 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/bd4a67998e9e82e2f113cd4bdc994afddcaf2e10
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•