1194063 - Text selection dialog does not disappear after 3 seconds on an empty input

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Steps to reproduce:

1. Copy some text.
2. Focus on an empty input.
3. The text selection dialog shows with a paste icon.

Actual results:
The dialog does not disappear after 3 seconds.

Expected results:
The dialog should disappear after 3 seconds timeout like it did on non-empty input.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Gaia has a bug that it triggers shortcut timeout in line 181, and cancel the timer in the first line of show() [1]. This causes issue when focusing on an empty input since currently gecko does not send another caretStateChange event after 3 seconds timeout.

Swapping line 181 and 182 should fix this bug. However, I'm thinking about another approach that gecko should send caretStateChange event after 3 seconds timeout on a collapsed selection whether the caret is actually visible to the user or not. In this way, Gaia could completely get rid of the shortcut timeout timer, and Gceko could maintain a consistent state that the first caret has Appearance::None in cursor mode after 3 seconds timeout.

[1] https://github.com/mozilla-b2g/gaia/blob/474784fc494519a0fab866407c0215aacf984ed9/apps/system/js/app_text_selection_dialog.js#L181-L182

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Always launch caret timer in cursor mode. (v1)

If the timer is not launched when the content is empty, the first caret
will always has Appearance::NormalNotShown, which is not consistent with
the behavior when the caret is shown when the content is not empty.

After this patch, Gaia will always receive an update event after 3
seconds timeout. Hence fixed a bug that the shortcut text dialog does
not hide after 3 seconds timeout.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Update link to point to the diagram directly. (v1)

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a764721aed40

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d7993b4a855
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bfc4d445286

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Leave-open for Gaia patch.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] aethanyc:1194063 > mozilla-b2g:master

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7d7993b4a855
https://hg.mozilla.org/mozilla-central/rev/5bfc4d445286

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Morris & Tim, thank you for the review.

Please check in the Gaia patch. Thanks.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/05b4ddbc7ee7747bd754da715c5f42a146976d4d