1194249 - Audio route is not changed when HDMI Display is connected on gonk

Status: RESOLVED INVALID

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Sotaro Ikeda [:sotaro]]

Since Bug 1186000, b2g supports HDMI display rendering.

On android, when HDMI display is connected to android device, the device's audio route is changed to the HDMI display. Same thing should be done also on gonk.

Comment 1

[Sotaro Ikeda [:sotaro]]

FYI: On android, HDMI display related audio route is controlled by WiredAccessoryManager.
  https://github.com/sotaroikeda/android-diagrams/blob/master/system/WiredAccessoryManager_5.1.pdf

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add HDMI audio route handling

The patch does not handle mediaserver died event yet.

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> Created attachment 8647699 [details] [diff] [review]
> patch - Add HDMI audio route handling
> 
> The patch does not handle mediaserver died event yet.

When the device is connected to HDMI Display, the phone's sound was stopped, but the Display did not have a sound.

Comment 4

[Sotaro Ikeda [:sotaro]]

Audio route was correctly changed to HDMI audio. Just audio volume was too small for HDMI audio out.

Comment 5

[Alastor Wu [:alwu]]

Hi, Sotaro,
You can try to set the volume of AUDIO_DEVICE_OUT_AUX_DIGITAL in AudioManager::SetStreamVolumeIndex().

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> FYI: On android, HDMI display related audio route is controlled by
> WiredAccessoryManager.
>  
> https://github.com/sotaroikeda/android-diagrams/blob/master/system/WiredAccessoryManager_5.1.pdf

I created additional diagrams related audio audio volume control
 https://github.com/sotaroikeda/android-diagrams/blob/master/media/VolumeUI_5.1.pdf
 https://github.com/sotaroikeda/android-diagrams/blob/master/media/MediaRouter_5.1.pdf
 https://github.com/sotaroikeda/android-diagrams/blob/master/media/MediaSession_5.1.pdf

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Alastor Wu [:alwu] from comment #5)
> Hi, Sotaro,
> You can try to set the volume of AUDIO_DEVICE_OUT_AUX_DIGITAL in
> AudioManager::SetStreamVolumeIndex().

Thanks for the info. It should work, though AudioManager's code clean up seems necessary to implement correctly.

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch - Add HDMI audio route handling

Temporary implementation, just to confirm the audio problem fix.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add HDMI audio route handling

Rebased.

Comment 10

[Sotaro Ikeda [:sotaro]]

On android M, when the device is connected to TV, the playback audio volume can be changed only between min/max. It is because, audio volume should be changed only by TV side.

attachment 8681066 [details] [diff] [review] does not have such control yet.

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add HDMI audio route handling

Update nits.

Comment 12

[Sotaro Ikeda [:sotaro]]

This is specific to gonk.