Closed Bug 1194274 Opened 9 years ago Closed 9 years ago

Top sites populate wrong favicon for blank tiles on rotation or refresh

Categories

(Firefox for iOS :: Home screen, defect)

Product:
Firefox for iOS
Component:
Home screen
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: fluffyemily, Assigned: fluffyemily)

References

Details

Attachments

(3 files)

IMG_4732.jpg
122.23 KB, image/jpeg
Details
IMG_4733.jpg
118.33 KB, image/jpeg
Details
Pull request
47 bytes, text/x-github-pull-request
bnicholson
: review+
tecgirl
: ui-review+
Details | Review
On a home page with top sites with blank favicons: STR rotate to landscape Expected: The same tile will still be blank Actual: The blank tile now has a favicon from another top site. [screenshot to come later]
Summary: Top sites populate wrong favicon for blank tiles on rotation → Top sites populate wrong favicon for blank tiles on rotation or refresh
tracking-fxios: ? → +
I'm pretty sure this is due to cell recycling not clearing the old favicon when the new favicon is nil
Assignee: nobody → etoop
Attached image IMG_4732.jpg —
Attached image IMG_4733.jpg —
Status: NEW → ASSIGNED
Attached file Pull request —
Attachment #8647595 - Flags: ui-review?(randersen)
Attachment #8647595 - Flags: review?(bnicholson)
Comment on attachment 8647595 [details] [review] Pull request Tiles remain blank for me.
Attachment #8647595 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8647595 [details] [review] Pull request Nice, LGTM.
Attachment #8647595 - Flags: review?(bnicholson) → review+
0a649b1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: