1194353 - Context menu in autocomplete=username field without password field present should show "Fill Username" menu.

Status: RESOLVED DUPLICATE of bug 1745918

(Toolkit :: Password Manager, defect, P2)

Description

[Bernardo Rittmeyer [:rittme]]

A username field without a password field present in the same form should show a "Fill Username" menu in it's context menu.

Comment 1

[Matthew N. [:MattN]]

Some relevant pieces of code:

https://searchfox.org/mozilla-central/rev/75294521381b331f821aad3d6b60636844080ee2/browser/actors/ContextMenuChild.jsm#491
https://searchfox.org/mozilla-central/rev/75294521381b331f821aad3d6b60636844080ee2/browser/base/content/nsContextMenu.js#731
https://searchfox.org/mozilla-central/source/toolkit/components/passwordmgr/LoginManagerContextMenu.jsm

Comment 2

[Chris Frey [:nautilus]]

Matthew I was wondering if there is a website to test this functionality easily? So I could see it not working and confirm it works when I fix it?

Comment 3

[Chris Frey [:nautilus]]

Attachment: Bug 1194353 - Make context menu show 'Fill Username' option when there is autocomplete=username field without password field

Comment 4

[Matthew N. [:MattN]]

Attachment: Test page

Comment 5

[Matthew N. [:MattN]]

Repeating STR from Phabricator here for QA to use for verification:

1. Load https://bug1194353.bmoattachments.org/attachment.cgi?id=9061791
2. Fill a fake username (e.g. "foo") and password (e.g. "bar") in the bottom form and submit it
3. Choose to save the login to Firefox in the doorhanger
4. Go back to https://bug1194353.bmoattachments.org/attachment.cgi?id=9061791
5. Right-click in the first username field on that page.

Expected result:

• The "Fill Username" menu item appears in the context menu
• When I select/hover "Fill Username", the menu should show the saved logins for that site, such as the "foo" one saved in step 3.
• When I choose the saved login (e.g. "foo"), it should fill the username ("foo") into the username field.

Comment 6

[Matthew N. [:MattN]]

Mark, I'm still an active developer and peer so please don't remove me from bugs. One doesn't need to be an employee to mentor.

Comment 7

[Mark Banner (:standard8)]

(In reply to Matthew N. [:MattN] from comment #6)

Mark, I'm still an active developer and peer so please don't remove me from bugs. One doesn't need to be an employee to mentor.

My apologies, that wasn't clear when I originally posted the list on firefox-dev (and I think you'd been idle for a time, but I could be wrong).

Comment 8

[Matthew N. [:MattN]]

I fixed bugs in Firefox 91 and 92 (which isn't that long ago when it's in your spare time) and still triage and review occasionally.

Comment 9

[Riya]

Is this bug still open?

Comment 10

[Dimi Lee [:dimi]]

This bug is fixed by Bug 1708455 if an input field has an associated form. As for <input> without an associated form, we don't support this case right now (See Bug 1745918).

Comment 11

[Dimi Lee [:dimi]]

This issue will be fixed once we implement Bug 1745918