1194360 - Build fails with "error: 'mozilla::jni::Class<Foo>::Class' names constructor"

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Bug 1192079 used inherited constructors, which was introduced in gcc 4.8, but we officially require gcc 4.7 and a lot of people are still using an older NDK that bundled gcc 4.7.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove use of inherited constructors (v1)

GeneratedJNIWrappers.h was updated in bug 1192079 to use inherited
constructors, which is a gcc 4.8 feature. Unfortunately many people are still
using an older version of NDK which only comes with gcc 4.7.

The patch is small and makes people's lives easier, so it seems worth it.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8647669 [details] [diff] [review]
Remove use of inherited constructors (v1)

Review of attachment 8647669 [details] [diff] [review]:
-----------------------------------------------------------------

Somehow all of the other C++11 stuff you're using managed to work in 4.7?

Comment 3

[Botond Ballo [:botond]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #2)
> Somehow all of the other C++11 stuff you're using managed to work in 4.7?

gcc 4.7 has pretty subtantial C++11 support - the only missing features are inherited constructors, ref-qualifies, and a couple of other minor things.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8044a09c3453

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8044a09c3453

Comment 7

[Allison Naaktgeboren :ally]

Central as of 2 minutes ago is still failing to build with the same set of cpp errors reported in 1194572.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #7)
> Central as of 2 minutes ago is still failing to build with the same set of
> cpp errors reported in 1194572.

Clobber build?

Comment 9

[Allison Naaktgeboren :ally]

it's working again. I had thought this bug was closed a while ago.