1194407 - Adding Firefox Emoji font

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for master

Hey Patryk,
can you check this before I ask Michael for r+?

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/moztt/commit/39462392383bd40894f1b5525a0997ec1390cd0e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G emoji reftest failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=2619447&repo=b2g-inbound

https://github.com/mozilla-b2g/moztt/commit/51ebaf824cc634665c5efcae95b8301ad1758c5e

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8649530 [details] [review]
patch for master

>https://github.com/mozilla-b2g/moztt/pull/70

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Ryan,

Here http://mxr.mozilla.org/mozilla-central/source/layout/reftests/text/reftest.list#188
we need to change line #188 and #189 from:

fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android||B2G) != emoji-03.html emoji-03-notref.html
fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android||B2G) == emoji-04.html emoji-04-ref.html

to:

fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android) != emoji-03.html emoji-03-notref.html
fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android) == emoji-04.html emoji-04-ref.html

and we need to land both patches together.

can you help me with this?

Thanks in advance :)

Comment 6

[Jan Keromnes [:janx]]

Attachment: Prepare layout reftests for Firefox Emoji font.

I was passing by, just giving a quick hand with this:
- Formatted change from comment 5 as a patch.
- Sent it to try (without the updated MozTT though, I don't know how to do that):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=596d98d664cf

Patch probably needs someone who can verify it actually works with the new MozTT, and also a review.

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Jan,

thanks a lot :) I think Ryan can help us?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Sorry, if I had been paying closer attention the first time around and noticed that they were TEST-UNEXPECTED-PASS, I probably would have just pushed the manifest follow-up on my own.

To run it through Try w/ the moztt change included, you'd need to mess around with the various manifests in b2g/config/emulator. That said, I think this is clear-cut enough that we don't need to bother. Let's just re-land the moztt change and push the reftest change to b2g-inbound.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://github.com/mozilla-b2g/moztt/commit/f5d65f5b17d9766d7925aefd0486a1e526ae9bf0

https://hg.mozilla.org/integration/b2g-inbound/rev/13fd8bc2185b

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Yey :) thanks guys, can we mark this RESOLVED:FIXED?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

It'll be resolved when the b2g-inbound push is merged to mozilla-central.

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Comment 13

[BMO Automation]

Firefox OS is not being worked on