Closed Bug 1194407 Opened 5 years ago Closed 2 years ago
Adding Firefox Emoji font
No description provided.
Hey Patryk, can you check this before I ask Michael for r+?
Attachment #8649530 - Flags: ui-review?(padamczyk)
Attachment #8649530 - Flags: ui-review?(padamczyk) → ui-review+
Attachment #8649530 - Flags: review?(mwu)
Thanks :) Landed to master: https://github.com/mozilla-b2g/moztt/commit/39462392383bd40894f1b5525a0997ec1390cd0e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Backed out for B2G emoji reftest failures. https://treeherder.mozilla.org/logviewer.html#?job_id=2619447&repo=b2g-inbound https://github.com/mozilla-b2g/moztt/commit/51ebaf824cc634665c5efcae95b8301ad1758c5e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8649530 [details] [review] patch for master >https://github.com/mozilla-b2g/moztt/pull/70
Hey Ryan, Here http://mxr.mozilla.org/mozilla-central/source/layout/reftests/text/reftest.list#188 we need to change line #188 and #189 from: fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android||B2G) != emoji-03.html emoji-03-notref.html fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android||B2G) == emoji-04.html emoji-04-ref.html to: fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android) != emoji-03.html emoji-03-notref.html fails-if(OSX==1006||/^Windows\x20NT\x20(5|6\.[0-2])/.test(http.oscpu)||gtkWidget||Android) == emoji-04.html emoji-04-ref.html and we need to land both patches together. can you help me with this? Thanks in advance :)
I was passing by, just giving a quick hand with this: - Formatted change from comment 5 as a patch. - Sent it to try (without the updated MozTT though, I don't know how to do that): https://treeherder.mozilla.org/#/jobs?repo=try&revision=596d98d664cf Patch probably needs someone who can verify it actually works with the new MozTT, and also a review.
Hey Jan, thanks a lot :) I think Ryan can help us?
Sorry, if I had been paying closer attention the first time around and noticed that they were TEST-UNEXPECTED-PASS, I probably would have just pushed the manifest follow-up on my own. To run it through Try w/ the moztt change included, you'd need to mess around with the various manifests in b2g/config/emulator. That said, I think this is clear-cut enough that we don't need to bother. Let's just re-land the moztt change and push the reftest change to b2g-inbound.
Yey :) thanks guys, can we mark this RESOLVED:FIXED?
It'll be resolved when the b2g-inbound push is merged to mozilla-central.
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 5 years ago → 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.