Closed Bug 1194467 Opened 9 years ago Closed 6 years ago

Lift sheriff permissions requirement for non-try "Cancel All" once bug 1077053 fixed

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1443087

People

(Reporter: armenzg, Unassigned)

References

Details

Is there a reason as to why I can't?

Are we limiting developers to cancel all?
Are you listed as a sheriff/staff in Treeherder? The "cancel all" button only shows up on try or to logged in isStaff users: https://github.com/mozilla/treeherder/blob/2e6b7b56c669c519f9ebe5ddcf65f895dabdfa41/ui/partials/main/jobs.html#L30

Canceling a single selected job should work for anyone anywhere.
Why do we add this restriction?

What does isStaff imply?
Summary: I can't stop builds from the Treeherder UI on alder → I can't cancel all from the Treeherder UI on alder
I think the history of this feature, is it was considered destructive enough we wanted to limit its access. We could adjust the degree of access though :)
Cancel all (via buildapi) cancels pending jobs too. Unfortunately for non-try this means the wrong jobs can get cancelled, due to coalescing - which is why the feature was limited to sheriffs, both in TBPL and Treeherder.

Once we're using mozci (or if buildapi were fixed in the meantime), I'm happy to lift that requirement.

I'm also happy to mark your account as having the sheriff permissions, if that helps?
Flags: needinfo?(armenzg)
Hi Ed, that plan works for me.

For now, I don't want sheriff permissions since I want to have the developer experience. Thanks though!
Flags: needinfo?(armenzg)
Depends on: 1077053
Priority: -- → P4
Summary: I can't cancel all from the Treeherder UI on alder → Lift sheriff permissions requirement for non-try "Cancel All" once bug 1077053 fixed
Component: Treeherder → Treeherder: Job Triggering & Cancellation
Priority: P4 → P3
This was fixed in bug 1443087.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Component: Treeherder: Job Triggering & Cancellation → TreeHerder
You need to log in before you can comment on or make changes to this bug.