1194467 - Lift sheriff permissions requirement for non-try "Cancel All" once bug 1077053 fixed

Status: RESOLVED DUPLICATE of bug 1443087

(Tree Management :: Treeherder, defect, P3)

Description

[Armen [:armenzg]]

Is there a reason as to why I can't?

Are we limiting developers to cancel all?

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Are you listed as a sheriff/staff in Treeherder? The "cancel all" button only shows up on try or to logged in isStaff users: https://github.com/mozilla/treeherder/blob/2e6b7b56c669c519f9ebe5ddcf65f895dabdfa41/ui/partials/main/jobs.html#L30

Canceling a single selected job should work for anyone anywhere.

Comment 2

[Armen [:armenzg]]

Why do we add this restriction?

What does isStaff imply?

Comment 3

[Jonathan French (:jfrench)]

I think the history of this feature, is it was considered destructive enough we wanted to limit its access. We could adjust the degree of access though :)

Comment 4

[Ed Morley [:emorley]]

Cancel all (via buildapi) cancels pending jobs too. Unfortunately for non-try this means the wrong jobs can get cancelled, due to coalescing - which is why the feature was limited to sheriffs, both in TBPL and Treeherder.

Once we're using mozci (or if buildapi were fixed in the meantime), I'm happy to lift that requirement.

I'm also happy to mark your account as having the sheriff permissions, if that helps?

Comment 5

[Armen [:armenzg]]

Hi Ed, that plan works for me.

For now, I don't want sheriff permissions since I want to have the developer experience. Thanks though!

Comment 7

[Ed Morley [:emorley]]

This was fixed in bug 1443087.