1194493 - the filename field of <input type=file> renders incorrectly in vertical writing mode with dir=rtl

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jonathan Kew [:jfkthame]]

Testcase:

  data:text/html,<div style="writing-mode:vertical-rl" dir=rtl><input type=file>

Result:

The text "No file selected." should be shown (vertically) as a placeholder, but it actually renders horizontally and is clipped so that only the first letter (and a bit) is visible.

Note that without dir=rtl, it renders as expected.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Ensure the 'mVertical' flag is set appropriately on the nsFontMetrics we use to draw text for an nsTextBoxFrame

This was a bug in the (rudimentary) vertical-drawing support in nsTextBoxFrame that was added in bug 1123284: it fails to set the mVertical flag on the nsFontMetrics before using it to draw, so we end up drawing in whatever direction the last user of these metrics had set. (Eventually, we should aim to get rid of nsTextBoxFrame and use nsTextFrame everywhere, with its more fully-developed bidi and vertical support, but for now this fixes the glaring bug.)

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Ensure the 'mVertical' flag is set appropriately on the nsFontMetrics we use to draw text for an nsTextBoxFrame

Oops, failed to refresh the patch before uploading, sorry for the noise.

Comment 3

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08ecdf06c553

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 8648017 [details] [diff] [review]
Ensure the 'mVertical' flag is set appropriately on the nsFontMetrics we use to draw text for an nsTextBoxFrame

Review of attachment 8648017 [details] [diff] [review]:
-----------------------------------------------------------------

The patch makes sense, but if this was the problem I don't understand why it worked before without dir=rtl.

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Simon Montagu :smontagu from comment #4)
> Comment on attachment 8648017 [details] [diff] [review]
> Ensure the 'mVertical' flag is set appropriately on the nsFontMetrics we use
> to draw text for an nsTextBoxFrame
> 
> Review of attachment 8648017 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The patch makes sense, but if this was the problem I don't understand why it
> worked before without dir=rtl.

Because the button and the textbox use the same nsFontMetrics; so in the case where the button is drawn first (ltr), the vertical flag has been set by that, and the textbox doesn't change it.

Comment 6

[Jonathan Kew [:jfkthame]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/22b685186a10600851a8a6f1d05608eb13e68baf
changeset:  22b685186a10600851a8a6f1d05608eb13e68baf
user:       Jonathan Kew <[e-mail]>
date:       Sun Aug 16 15:09:08 2015 +0100
description:
Bug 1194493 - Ensure the 'mVertical' flag is set appropriately on the nsFontMetrics we use to draw text for an nsTextBoxFrame. r=smontagu

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/22b685186a10