Closed
Bug 1194505
Opened 10 years ago
Closed 10 years ago
Report the sanity test snapshot when we detect a failure
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
|
5.47 KB,
patch
|
mattwoodrow
:
review+
vladan
:
review+
|
Details | Diff | Splinter Review |
We believe we are seeing some false negatives via the sanity test. To help understand why, I'd like to capture PNGs of the snapshots into telemetry for a few weeks.
The easiest way to do this is to just stick the snapshot as a data URI into the Telemetry environment for graphics.
I painted a green triangle over the existing test and the resulting snapshot we uploaded was ~2500 characters (so, ~5000 bytes of storage when using UCS-2). So that's large, but not ridiculous, and this should be temporary.
| Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8647768 -
Flags: review?(matt.woodrow)
| Assignee | ||
Updated•10 years ago
|
Attachment #8647768 -
Flags: review?(vdjeric)
Comment 2•10 years ago
|
||
Comment on attachment 8647768 [details] [diff] [review]
patch
Review of attachment 8647768 [details] [diff] [review]:
-----------------------------------------------------------------
Please also file a bug to back this out in a week
Attachment #8647768 -
Flags: review?(vdjeric) → review+
Updated•10 years ago
|
Attachment #8647768 -
Flags: review?(vdjeric)
Attachment #8647768 -
Flags: review?(matt.woodrow)
Attachment #8647768 -
Flags: review+
Updated•10 years ago
|
Attachment #8647768 -
Flags: review?(vdjeric) → review+
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment 5•10 years ago
|
||
How's this data looking & can you file the followup to back it out
Flags: needinfo?(dvander)
| Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #5)
> How's this data looking & can you file the followup to back it out
bug 1196128 filed. I'm on PTO for the next three days, so I'll do the data analysis and backout on Monday.
No longer depends on: 1196128
Flags: needinfo?(dvander)
You need to log in
before you can comment on or make changes to this bug.
Description
•